Skip to content

Conversation

@ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Apr 2, 2025

  • move EIP category to Core
  • minor edits on language, more explanation or links to helper code
  • polish missing EIP sections
  • add security rationale, referencing this document from @fradamt : https://hackmd.io/@fradamt/SyutzooCkg

@ralexstokes ralexstokes requested a review from eth-bot as a code owner April 2, 2025 21:47
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Apr 2, 2025
@ralexstokes ralexstokes closed this Apr 2, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 2, 2025

✅ All reviewers have approved.

@ralexstokes ralexstokes reopened this Apr 2, 2025
@ralexstokes ralexstokes marked this pull request as draft April 2, 2025 21:47
@eth-bot eth-bot added the a-review Waiting on author to review label Apr 2, 2025
@eth-bot eth-bot changed the title Polish EIP, expand rationale Update EIP-7594: Polish EIP, expand rationale Apr 2, 2025
@ralexstokes ralexstokes force-pushed the eip7594/add-rationale branch 4 times, most recently from acba5cc to 691064a Compare April 2, 2025 21:55
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 2, 2025
@ralexstokes ralexstokes force-pushed the eip7594/add-rationale branch from 6abeb8f to e26bea7 Compare May 1, 2025 22:58
@ralexstokes
Copy link
Member Author

still reviewing the security section with @fradamt and @MarcoPolo

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 25, 2025
@github-actions
Copy link

The commit 63cae7d (as a parent of 2e44014) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 25, 2025
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 25, 2025

Validators are assumed to have marginally higher requirements to participate on the network. PeerDAS introduces a custody requirement that scales with the validator count so that nodes with more resources can contribute to a more stable backbone that makes the global network more robust.

### Column sampling vs row sampling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add that extending columns (including proof computation) has to be done just in time, in the critical path, whereas rows can be extended in advance and the proof computation can even be outsourced to the senders, as we do in the previous section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 118 to 131
| $\epsilon$ | $n\epsilon$ (nodes) | Upper bound on $\mathbb{P}$ |
|:-----------:|:---------------------:|:---------------------:|
| 0.0 | 0 | 2.36*10^37 |
| 0.1 | 1 000 | 10^-960.9 |
| 0.2 | 2 000 | 10^-2607.9 |
| 0.3 | 3 000 | 10^-4536.5 |
| 0.4 | 4 000 | 10^-6674.8 |
| 0.5 | 5 000 | 10^-8995.6 |
| 0.6 | 6 000 | 10^-11491.3 |
| 0.7 | 7 000 | 10^-14169.4 |
| 0.8 | 8 000 | 10^-17057.3 |
| 0.9 | 9 000 | 10^-20226.8 |
| 1.0 | 10 000 | 10^-24045.0 |

Copy link
Contributor

@fradamt fradamt Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prioritize values in the most interesting range, i.e. small and near the transition from unsafe to safe. These are the log2 values of the bound for [0.01, 0.02, 0.03, 0.04, 0.05]:

127.43879660818209
-66.57921254923122
-337.35094215358595
-658.5475731661436
-1017.6532434515411

In other words, these parameters are good for epsilon >= 2-3%, depending on the failure probability you're ok with

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, could show (as an image or table) the minimum number of samples to achieve a certain failure probability for a given epsilon, e.g. this plot is with failure probability 2^-128, n = 10k

image

Comment on lines +120 to +126
| $\epsilon$ | $n\epsilon$ (nodes) | Upper bound on $\mathbb{P}$ |
|:-----------:|:--------------------:|:-----------:|
| 0.01 | 1 00 | 10^38.36 |
| 0.02 | 2 00 | 10^-20.04 |
| 0.03 | 3 00 | 10^-101.55 |
| 0.04 | 4 00 | 10^-198.24 |
| 0.05 | 5 00 | 10^-306.34 |
Copy link
Contributor

@fradamt fradamt Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| $\epsilon$ | $n\epsilon$ (nodes) | Upper bound on $\mathbb{P}$ |
|:-----------:|:--------------------:|:-----------:|
| 0.01 | 1 00 | 10^38.36 |
| 0.02 | 2 00 | 10^-20.04 |
| 0.03 | 3 00 | 10^-101.55 |
| 0.04 | 4 00 | 10^-198.24 |
| 0.05 | 5 00 | 10^-306.34 |
| $\epsilon$ | $n\epsilon$ (nodes) | Upper bound on $\mathbb{P}$ |
|:----------:|:-------------------:|:---------------------------:|
| 0.01 | 100 | $10^{38}$ |
| 0.02 | 200 | $10^{-20}$ |
| 0.03 | 300 | $10^{-101}$ |
| 0.04 | 400 | $10^{-198}$ |
| 0.05 | 500 | $10^{-306}$ |

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2025 13:52
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ff212a2 into ethereum:master Sep 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants