Skip to content

Comments

Update EIP-7805: IL building algorithm#9396

Open
Marchhill wants to merge 28 commits intoethereum:masterfrom
Marchhill:focil-execution-patch-2
Open

Update EIP-7805: IL building algorithm#9396
Marchhill wants to merge 28 commits intoethereum:masterfrom
Marchhill:focil-execution-patch-2

Conversation

@Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Feb 22, 2025

Suggests building IL using nondeterminism and bias, explained here

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Feb 22, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 22, 2025

File EIPS/eip-7805.md

Requires 1 more reviewers from @soispoke

@eth-bot eth-bot added the a-review Waiting on author to review label Feb 22, 2025
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 22, 2025
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Feb 24, 2025
@Marchhill Marchhill marked this pull request as ready for review May 27, 2025 11:49
@Marchhill Marchhill requested a review from eth-bot as a code owner May 27, 2025 11:49
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 27, 2025
Marchhill and others added 2 commits May 27, 2025 13:39
Co-authored-by: JihoonSong <jihoonsong@users.noreply.github.com>
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 27, 2025
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍

@Marchhill
Copy link
Contributor Author

Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍

Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building

@jochem-brouwer
Copy link
Member

Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍

Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building

Ah ok! You could (for the diff) also point the original PR to only present the relevant diff here and not the changes of the OG PR also 😄 👍

@Marchhill
Copy link
Contributor Author

Some minor comments regarding clarification, plus have linked my thoughts on the current idea of changes to the engine API and a disagreement on how to construct ILs 😄 👍

Thanks for feedback! Just to be clear, this PR is just to add the IL building stuff. Most of these comments apply to the original PR it's built on so will make any changes there that aren't related to IL building

Ah ok! You could (for the diff) also point the original PR to only present the relevant diff here and not the changes of the OG PR also 😄 👍

Sure, you can see the diff here: https://github.com/Marchhill/EIPs/pull/4/files

@github-actions
Copy link

The commit 4b95936 (as a parent of 5fef53b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core w-stale Waiting on activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants