-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7702: Proxy the storage of a delegation to its unique deleterminstic keys #8762
Conversation
…terminstic address
File
|
Co-authored-by: Phil Ngo <[email protected]>
Co-authored-by: Phil Ngo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no way to fix the html and dns ? everything else seems to be good im just curious if it will cause depression in other branches that may be bigger than what is specified its simple a concern i thought should be addressed or voiced that being said i currently am unfortunately without a workaround or fix at this moment ...
X
I don't support this change. It creates division between 7702 accounts and full smart contract wallets. I contend that this problem should be solved at the app layer. Even if people disagree with that, a protocol solution should absolutely solve the problem for both full smart contract wallets and 7702 accounts. |
Co-authored-by: Guillaume Ballet <[email protected]>
imo we shouldn't deliver a bad UX when it is simple enough to solve the problem. compromising one featureset for parity with other sounds like a bad idea either this or the storage of 7702 should be ephemeral and not banning create so that contracts can create their own storage islands to store their data |
The commit 725ed31 (as a parent of e55449f) contains errors. |
When the ability to upgrade an EOA to a real SCW finally does happen, it’s not feasible to assume that every user and / or every wallet will go through an EOA’s 7702 history and modify the SCW’s code to avoid storage conflicts. One bandaid now is preferable to twenty bandaids later, especially since we don’t (and can’t) know the full extent of how 7702 will be used. |
closing PR as suggestion was not accepted |
Solve the problem of storage conflicting across delegations