Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7702: Proxy the storage of a delegation to its unique deleterminstic keys #8762

Closed
wants to merge 14 commits into from

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jul 26, 2024

Solve the problem of storage conflicting across delegations

@g11tech g11tech requested a review from eth-bot as a code owner July 26, 2024 12:51
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 26, 2024

File EIPS/eip-7702.md

Requires 1 more reviewers from @adietrichs, @lightclient, @SamWilsn, @vbuterin

@eth-bot eth-bot added the a-review Waiting on author to review label Jul 26, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 26, 2024
EIPS/eip-7702.md Outdated Show resolved Hide resolved
EIPS/eip-7702.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 26, 2024
EIPS/eip-7702.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 26, 2024
EIPS/eip-7702.md Outdated Show resolved Hide resolved
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 26, 2024
@g11tech g11tech changed the title Update EIP-7702: Proxy the storage of a delegation to its unique deleterminstic address Update EIP-7702: Proxy the storage of a delegation to its unique deleterminstic keys Jul 26, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 26, 2024
EIPS/eip-7702.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 26, 2024
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@MustardseedX MustardseedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no way to fix the html and dns ? everything else seems to be good im just curious if it will cause depression in other branches that may be bigger than what is specified its simple a concern i thought should be addressed or voiced that being said i currently am unfortunately without a workaround or fix at this moment ...

X

@lightclient
Copy link
Member

I don't support this change. It creates division between 7702 accounts and full smart contract wallets. I contend that this problem should be solved at the app layer. Even if people disagree with that, a protocol solution should absolutely solve the problem for both full smart contract wallets and 7702 accounts.

EIPS/eip-7702.md Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Ballet <[email protected]>
@g11tech
Copy link
Contributor Author

g11tech commented Jul 30, 2024

I don't support this change. It creates division between 7702 accounts and full smart contract wallets. I contend that this problem should be solved at the app layer. Even if people disagree with that, a protocol solution should absolutely solve the problem for both full smart contract wallets and 7702 accounts.

imo we shouldn't deliver a bad UX when it is simple enough to solve the problem. compromising one featureset for parity with other sounds like a bad idea

either this or the storage of 7702 should be ephemeral and not banning create so that contracts can create their own storage islands to store their data

Copy link

The commit 725ed31 (as a parent of e55449f) contains errors.
Please inspect the Run Summary for details.

@thogard785
Copy link

When the ability to upgrade an EOA to a real SCW finally does happen, it’s not feasible to assume that every user and / or every wallet will go through an EOA’s 7702 history and modify the SCW’s code to avoid storage conflicts.

One bandaid now is preferable to twenty bandaids later, especially since we don’t (and can’t) know the full extent of how 7702 will be used.

@g11tech
Copy link
Contributor Author

g11tech commented Sep 2, 2024

closing PR as suggestion was not accepted

@g11tech g11tech closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants