Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-2982: Fix typos #8394

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Update EIP-2982: Fix typos #8394

merged 1 commit into from
Apr 24, 2024

Conversation

clonefetch
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@clonefetch
Update EIP-2982: Fix typos
932ec60 
Signed-off-by: clonefetch <[email protected]>
@clonefetch clonefetch requested a review from eth-bot as a code owner April 9, 2024 02:41
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-informational labels Apr 9, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 9, 2024 •
edited
Loading

File EIPS/eip-2982.md

Requires 1 more reviewers from @djrtwo, @vbuterin
Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 9, 2024
manojava98
manojava98 approved these changes Apr 13, 2024
View reviewed changes
Copy link

@manojava98 manojava98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@clonefetch
Copy link
Contributor Author

looks good!

Thanks.

If there is andthing need I to do, Please fell free to tell me.

@poojaranjan poojaranjan mentioned this pull request Apr 16, 2024
Closed
19 tasks
@SamWilsn SamWilsn merged commit 9b0a632 into ethereum:master Apr 24, 2024
8 of 10 checks passed
@github-actions GitHub Actions
Copy link

The commit 932ec60 (as a parent of 23f4ddb) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 24, 2024
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@clonefetch @GAEAlimited
Update EIP-2982: Fix typos (ethereum#8394)
8bc16fd 
Signed-off-by: clonefetch <[email protected]>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@clonefetch @blacksnow2
Update EIP-2982: Fix typos (ethereum#8394)
c90cd48 
Signed-off-by: clonefetch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojava98 manojava98 manojava98 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-informational w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clonefetch @eth-bot @manojava98 @SamWilsn