Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-152: Fix reference test #8390

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update EIP-152: Fix reference test #8390

merged 1 commit into from
Aug 20, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 4, 2024

The solidity example with the reference test of https://datatracker.ietf.org/doc/html/rfc7693#appendix-A is at least confusing because it declares values of type bytes8 using a literal of length of 4 bytes.

@chfast
EIP-152: Fix reference test
8da81ce 
The solidity example with the reference test of https://datatracker.ietf.org/doc/html/rfc7693#appendix-A is at least confusing because it declares values of type `bytes8` using a literal of length of 4 bytes.
@chfast chfast requested a review from eth-bot as a code owner April 4, 2024 22:23
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Apr 4, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 4, 2024 •
edited
Loading

File EIPS/eip-152.md

Requires 1 more reviewers from @MadeofTin, @mhluongo, @pdyraga

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 4, 2024
@eth-bot eth-bot changed the title EIP-152: Fix reference test Update EIP-152: Fix reference test Apr 4, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 4, 2024
@poojaranjan poojaranjan mentioned this pull request Apr 11, 2024
Closed
16 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 16, 2024
Closed
19 tasks
SamWilsn
SamWilsn approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs an author approval

@poojaranjan poojaranjan mentioned this pull request Jun 4, 2024
Closed
6 tasks
@xinbenlv
Copy link
Contributor

xinbenlv commented Jun 5, 2024

For this kind of fix, can we just lower the requirement to just 2 editor-s approval? or even one should be ok

@poojaranjan poojaranjan mentioned this pull request Jun 6, 2024
Closed
18 tasks
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 26, 2024
@poojaranjan poojaranjan mentioned this pull request Jul 4, 2024
Closed
10 tasks
@poojaranjan poojaranjan mentioned this pull request Jul 17, 2024
Closed
9 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Aug 7, 2024
@SamWilsn SamWilsn reopened this Aug 20, 2024
@github-actions GitHub Actions
Copy link

The commit 8da81ce (as a parent of 447384d) contains errors.
Please inspect the Run Summary for details.

@SamWilsn SamWilsn merged commit 5510973 into ethereum:master Aug 20, 2024
20 of 27 checks passed
@chfast
Copy link
Member Author

chfast commented Aug 20, 2024

Thank you for handling this.

@chfast chfast deleted the patch-3 branch August 20, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv approved these changes

@lightclient lightclient lightclient approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chfast @eth-bot @xinbenlv @lightclient @SamWilsn @g11tech