-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-4844: Rename gasPrice to baseFee #8095
Conversation
Type 2 transactions already use the "base fee" nomenclature. This change makes 4844 transactions consistent with that naming scheme.
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not necessarily against, but the data cost isn't exactly a "base" of the fee because it is exactly what the user will pay. There is no priority component of the data gas price.
Curious if other authors have thoughts on this?
For type 2 transactions, the "base fee" is the fee that is automatically determined and charged by the protocol and burnt. The same is true for this fee IIUC, which is why it feels like it should share naming convention. Just as with type 2 transactions, other fees are likely necessary to incentivize inclusion, but that feels out of scope to me for determining the name of this fee. |
FWIW I've been using this terminology already in some of the OP-stack 4844 work as I find it more clear, e.g.: ethereum-optimism/docs#386 |
We're talking about a header name though (or I guess in this gas, a value computed from a header value), the tx name just follows the value in the header. In 1559, there are multiple fee components, thus "base fee" name. In 4844, only a single fee component, therefore "gasprice". In both cases, the tx name is "max_xxxx_per_gas". |
In hindsight, I think EIP-1559 should have named it |
i think constants defintely can be changed becuase they are base fee part of constants anyway |
I guess the opcode is already using the BLOBBASEFEE terminology https://eips.ethereum.org/EIPS/eip-7516 |
I want to add that internally in Geth this is called blob base fee which I agree is the more accurate name. blobGasPrice can be confusing because of the legacy tx's gas price which goes to the miner. Or we call this "burntFee", so the intention becomes clear. |
I like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rename was accepted/not contested in Jan 18 ACD, so lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Type 2 transactions already use the "base fee" nomenclature. This change makes 4844 transactions consistent with that naming scheme.