Update EIP-4844: add data_gas_used to header#7062
Conversation
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
data_gas_used to headerdata_gas_used to header
|
note, just an idea, wanted to see what it actually looked like to do this |
|
I find this easier to understand. (...I've lost track of how many times I've gotten confused over parent vs current block for gathering appropriate data for blob pricing in the current spec.) Not sure how we trade that off against requiring another header field though. |
IMO there is very little difference between adding one additional header field vs. two. |
yperbasis
left a comment
yperbasis
left a comment
There was a problem hiding this comment.
Yes, this is less confusing and error-prone.
lightclient
force-pushed
the
add-data-gas-used
branch
from
972c95f to
88b8355
Compare
lightclient
force-pushed
the
add-data-gas-used
branch
from
88b8355 to
e8ae088
Compare
|
Had to rebase - changes should be the same though. |
lightclient
force-pushed
the
add-data-gas-used
branch
3 times, most recently
from
a13bda1 to
939170c
Compare
lightclient
force-pushed
the
add-data-gas-used
branch
from
939170c to
5245d43
Compare
adietrichs
left a comment
adietrichs
left a comment
There was a problem hiding this comment.
left some whitespace nitpicks, but LGTM.
Co-authored-by: Ansgar Dietrichs <adietrichs@gmail.com>
|
applied suggestions from @adietrichs, going to undraft now |
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Implement ethereum/EIPs#7062 and ethereum/EIPs#7095. Pick up ledgerwatch/erigon-lib#1006.
6 participants
At the moment, EIP-4844 uses the
excess_data_gasfrom a block's parent header in order to determine the data gas price of transactions in the current block. This is a bit different than EIP-1559 which first ensures the header'sbase_feeis correctly derived from the parent header, then proceeds to use that value for further gas price calculation.tldr;
excess_data_gasis pricing for next block, whilebase_feeis pricing for current block -- this PR aligns them so that both represent pricing information for the current block