Update EIP-4844: Cleanup transaction network payload references#7038
Merged
eth-bot merged 4 commits intoethereum:masterfrom May 30, 2023
Merged
Update EIP-4844: Cleanup transaction network payload references#7038eth-bot merged 4 commits intoethereum:masterfrom
eth-bot merged 4 commits intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
lightclient
reviewed
May 22, 2023
lightclient
reviewed
May 22, 2023
hwwhww
reviewed
May 25, 2023
jflo
reviewed
May 25, 2023
g11tech
force-pushed
the
fix-4844-tx-network-payload
branch
from
e0f0265 to
3543e2f
Compare
add blob flattening 4844: nit, opcode -> instruction apply feedback apply feedback
g11tech
force-pushed
the
fix-4844-tx-network-payload
branch
from
3543e2f to
4ffda41
Compare
Contributor
Author
|
rebased and resolved conflicts |
lightclient
reviewed
May 30, 2023
lightclient
reviewed
May 30, 2023
lightclient
approved these changes
May 30, 2023
Member
lightclient
left a comment
lightclient
left a comment
There was a problem hiding this comment.
LGTM, sorry for the tennis match. Thank you.
eth-bot
approved these changes
May 30, 2023
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This was referenced May 30, 2023
Contributor
Author
no problem 🙂 , thanks for the edits and feedback ❤️ 🙏 |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to
Cleans up network payload references:
[tx_payload, blobs, commitments, proofs]rather than current [tx_payload, kzgs, blobs, kzg_proofs]i.e. blobs first then commitments and proofs rather than blobs in middle of commitments and proofs