Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Allow links to the Yellow Paper #6834

Closed

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Apr 5, 2023

Split off from #6306

@SamWilsn SamWilsn requested a review from eth-bot as a code owner April 5, 2023 14:25
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Apr 5, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 5, 2023

File EIPS/eip-1.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

@eth-bot eth-bot changed the title Update eip-1.md: Allow links to the Yellow Paper Update EIP-1: Allow links to the Yellow Paper Apr 5, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 5, 2023
@lightclient
Copy link
Member

I'm strongly against adding the yellow paper preemptively (as discussed on EIPIP). I would like to see something which is not / cannot be expressed in the execution specs, but is expressed in the yellow paper.

In my eyes, the yellow paper is a deprecated resource.

@xinbenlv
Copy link
Contributor

xinbenlv commented Apr 19, 2023

On https://github.com/ethereum-cat-herders/EIPIP/issues/226

@SamWilsn and @gcolvin expressed support to allow linking to Yellow Paper .


I personally support allowing linking to Yellow Paper.

I would like to see something which is not / cannot be expressed in the execution specs, but is expressed in the yellow paper.

I believe it's not a policy in EIP-1 or EIP-5757 that a source need to demonstrate another source couldn't express, so I don't think this is a valid argument.

In my eyes, the yellow paper is a deprecated resource.

Most of the things in Yellow Paper still holds. I would be interested in seeing when author attempt to link to Yellow Paper to demonstrate some part of the protocol that no longer holds and it's up to our editor's job to point out when a link was incorrectly being linked.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 15, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meets the requirements set out by EIP-5757, although since @lightclient is our resident Core dev expert and he suggests it's deprecated as a source, I recommend that all links to it have a warning EIPW annotation attached to them.

FWIW I would love to see the yellow paper updated. I might take that on as a project some time.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 16, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 30, 2023
@SamWilsn
Copy link
Contributor Author

Closed in favour of #7884

@SamWilsn SamWilsn closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants