Update EIP-3540: Restrict EOF version in create#6052
Merged
eth-bot merged 1 commit intoethereum:masterfrom Dec 1, 2022
Merged
Conversation
github-actions
Bot
added
c-update
Collaborator
All tests passed; auto-merging...(pass) eip-3540.md
|
gumb0
reviewed
Nov 28, 2022
| 2. If *code's container* has EOF1 prefix it must be valid EOF1 code. | ||
| 1. If *initcode's container* has EOF1 prefix it MUST be valid EOF1 code. | ||
| 2. If *code's container* has EOF1 prefix it MUST be valid EOF1 code. | ||
| 3. If *initcode's container* is valid EOF1 code the result *code's container* MUST be valid EOF1 code (i.e. EOF1 initcode MUST NOT produce legacy code). |
Member
There was a problem hiding this comment.
(Maybe something like "returning empty code is still allowed")
Member
Author
There was a problem hiding this comment.
What does returning empty do?
Member
There was a problem hiding this comment.
I think it creates account with empty code.
Member
There was a problem hiding this comment.
Since empty isn't valid EOF code, I think we should disallow.
Member
There was a problem hiding this comment.
Can we just put a note that empty code is invalid? cc @gumb0
gumb0
reviewed
Nov 28, 2022
gumb0
reviewed
Nov 28, 2022
lightclient
previously approved these changes
Nov 30, 2022
axic
force-pushed
the
eip-3540_create_restrictions
branch
from
32941c4 to
c6f1c9f
Compare
axic
reviewed
Dec 1, 2022
axic
previously approved these changes
Dec 1, 2022
chfast
force-pushed
the
eip-3540_create_restrictions
branch
from
208a943 to
499a3c2
Compare
eth-bot
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forbid EOF → legacy contract creation.