Add EIP-6051: Private Key Encapsulation#6051
Conversation
…ess of the private key
|
A critical exception has occurred: |
Co-authored-by: xinbenlv <zzn@zzn.im>
|
Hi @xinbenlv I had pushed some more commits to address all issues except the |
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: xinbenlv <zzn@zzn.im>
Hi @xinbenlv thank you again for the very careful and very detailed reviews. I can see why EIP editors are so overwhelmed. I really appreciate what you had done here. I think I have fixed all issues. I also ran another round with grammarly.com and fixed almost all issues it suggests (with very few I did not agree with it). Please review again when you do find time. |
|
From a technical perspective, I personally still think, if the EIP is defining a way to encapsulate and unwrap private key via |
xinbenlv
left a comment
There was a problem hiding this comment.
I think this is good to merge as a draft now. Defer to @Pandapip1 @SamWilsn to follow up the merging.
weiji-cryptonatty
left a comment
There was a problem hiding this comment.
suggestions accepted
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: