Add EIP-3326: wallet_switchEthereumChain

[rekmarks]

This PR adds EIP-3326, specifying the wallet_switchEthereumChain RPC method.

Link to rendered file: https://github.com/rekmarks/EIPs/blob/3326-create/EIPS/eip-3326.md

[lightclient]

@rekmarks this is still a draft PR, but I see it hasn't been modified in 2 months. Are you ready for it to be reviewed and merged as a draft EIP?

[Chanh3939]

EIPS/eip-3326.md

[994hfdgh]

等待中

[taylorjdawson]

@rekmarks Do we have a timeline on this?

[Cvada98]

.

[axic]

@rekmarks this is still a draft PR, but I see it hasn't been modified in 2 months. Are you ready for it to be reviewed and merged as a draft EIP?

Repeating @lightclient's question here 👀

[derivativedegen]

can confirm this is working in production though, and it makes network switching absolutely flawless. thank you!

[rekmarks]

Hey @axic and @lightclient, sorry for the delay. As people have noted (thanks for the positive feedback!), this is already merged and in production. I think it would be straightforward to finalize. However, given the eth1 JSON-RPC API work, I'm wondering whether it's worth our time to actually merge and ultimately finalize this EIP.

I'm currently out of the loop with the eth1 RPC API efforts, but is there a place in that repo for methods like this? @lightclient, are you the right person to ask about that?

[MicahZoltu]

My recommendation is to convert this to a PR against https://github.com/ethereum/eth1.0-specs/blob/master/json-rpc/spec.json which is where the JSON-RPC spec now lives.

Things are a bit weird since in this case this isn't actually a JSON-RPC method, but it is structured and served in the same places as JSON-RPC so that is probably the best place for it?

[axic]

I still think it is useful to get it finalised here given
a) it is already written, and
b) all the relevant other methods (such as #3085 and the provider API) are described here.

The linked JSON RPC spec does not even contain wallet_addEthereumChain (#3085).

If all these are moved to a new repo, hopefully all of them get at least the finalised ERCs included, which is not yet the case.

[sweetmantech]

would love to see this merged 🚀

[eth-bot]

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - File with name EIPS/eip-3326.md is new and new files must be reviewed
 - This PR requires review from one of [@micahzoltu, @lightclient, @arachnid, @cdetrio, @souptacular, @vbuterin, @nicksavers, @wanderer, @gcolvin, @axic]

@MicahZoltu @lightclient @Arachnid @cdetrio @Souptacular @vbuterin @nicksavers @wanderer @gcolvin @axic

[rekmarks]

@axic alright, let's get this merged!

@MicahZoltu, I agree with you that this should live in the eth1 specs repo. I'll make sure someone from MetaMask PRs the methods we've authored there.

Just one question, when you say that wallet_switchEthereumChain "isn't actually a JSON-RPC method", you mean because it's not implemented by clients?

[lightclient]

FYI, the new api repo is https://github.com/ethereum/eth1.0-apis, not the specs repo anymore.

With that said, I'm not sure if the wallet namespace should also live there. Currently, the repo is focused on specifying the RPC methods for consensus clients.

[lightclient]

I think this line is unnecessary, security considerations should already be an important section for implementers to read :)

[Hbutlercapone]

Add EIP-3326: wallet_switchEthereumChain#3326

[Hbutlercapone]

Add EIP-3326 wallet_switchEthereumChain #3326

[Saldanaf1987]

My files been updated

[mohasin1997]

Hi

[Hbutlercapone]

Hello

…

On Tue, Mar 28, 2023, 10:36 AM mohasin1997 ***@***.***> wrote: Hi — Reply to this email directly, view it on GitHub <#3326 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT5C7EDYUHQWLWP5WPUIRGLW6LZODANCNFSM4YUFW34Q> . You are receiving this because you commented.Message ID: ***@***.***>

[mohasin1997]

Hi mohasin