Add ERC-2212 markdown #2444

PaulRBerg · 2019-12-20T00:23:06Z

As per @axic's comment in #2212, I add the markdown version of ERC-2212 so it can be viewed on eips.ethereum.org.

axic · 2019-12-20T21:33:04Z

Thanks! This seems to also contains 1620, can you please remove it so that 2212 can be properly reviewed?

PaulRBerg · 2019-12-21T12:57:41Z

Sorted.

EIPS/eip-2212.md

axic · 2019-12-21T14:42:49Z

EIPS/eip-2212.md

+
+Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).
+
+@PaulRBerg and @SablierHQ.


What are these for?

I saw the copyright in other standards and wrote one here too. I'll remove it if its place is not here.

There is no copyright with CC0, if I understand it correctly.

That is why it is "waived" - it's a small thing, happy to remove it if you think it is superfluous.

@MicahZoltu @lightclient any comments here?

axic · 2019-12-21T14:59:33Z

EIPS/eip-2212.md

+[Ownable](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/ownership/Ownable.sol). For
+brevity, we haven't included any method for assigning or transferring ownership.
+
+Every time we refer to cTokens, we mean Compound Tokens, as defined in the official


Hm, I don't see a specification there. What is the interface of a cToken and why does ERC-2212 need to use cTokens and not any ERC-20 ?

Afaik, Compound did not publish the interface for cTokens in this repo, only on their website.

This spec can't use ERC-20, because of the need to calculate interest and withhold a portion of it. Then, I didn't include other protocols other than Compound merely because it would've taken more time and I wanted to get it out there and get feedback.

If you read the latest messages in #2212, you can see that we started working on a v2, which is protocol-agnostic. v1 is not.

PaulRBerg · 2020-01-14T18:12:51Z

The Travis build failed with this error:

apt-get install failed
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install libcurl4-openssl-dev" failed and exited with 100 during .

Is this a normal failure?

axic · 2020-09-08T10:58:11Z

Please rebase and fix any potential validation errors, if you are still pursuing this.

axic · 2020-09-08T21:13:03Z

EIPS/eip-2212.md

+brevity, we haven't included any method for assigning or transferring ownership.
+
+Every time we refer to cTokens, we mean Compound Tokens, as defined in the official
+[documentation](https://compound.finance/ctokens). These are ERC-20 tokens with an interest accrual feature built in.


This link is now dead.

Is it? I just opened it and it worked for me.

It doesn't go to any kind of documentation, just a marketing page. There should be a link to a specification, if it cannot be another ERC.

Fair enough.

axic · 2020-09-08T21:25:47Z

EIPS/eip-2212.md

+SHOULD revert if `staker` doesn't have an active stake. SHOULD revert if `tokenAddress` doesn't match either the cToken or the underlying of the stake.
+
+```solidity
+function balanceOf(address staker, address tokenAddress) external view returns (uint256);


Since the ABI encoding ignores the parameter names, this may be something prone to collisions.

EIPS/eip-2212.md

axic · 2020-09-08T21:31:28Z

EIPS/eip-2212.md

+**Triggers Event**: [DiscardCToken](#discardctoken)
+
+```solidity
+function discardCToken(address cTokenAddress) external


I think it would be better using the type system if there is a requirement to use "cToken"s.

axic · 2020-09-08T21:33:46Z

Please consider my comments about interfaces in #2467.

I'm not sure I fully understand the specification, how an implementation would do "staking". Furthermore the lack of documentation about cTokens, yet the dependency on them makes this specification hard to understand.

@MicahZoltu do you have any comments?

PaulRBerg · 2020-09-09T11:24:03Z

I'm not sure I fully understand the specification, how an implementation would do "staking". Furthermore the lack of documentation about cTokens, yet the dependency on them makes this specification hard to understand.

Yeah "staking" is not the best wording I could've come up with. The idea is that people deposit stablecoins into a smart contract and the contract starts earning interest on the deposits using cTokens.

I agree that cTokens are more like a proprietary product and lack a comprehensive documentation.

Since I've stopped promoting this ERC in the meantime, I'm going to close the PR.

axic · 2020-09-09T11:36:58Z

Sorry for the hassle and thanks for being considerate here. Maybe if you do not plan to promote this idea further, it would be useful to leave a similar message on #2212 and/or close it.

PaulRBerg · 2020-09-09T11:40:47Z

No worries, thanks for your support. I just updated the other thread.

PaulRBerg force-pushed the feat/erc2212 branch from 72c52ee to 5682e56 Compare December 20, 2019 00:58

axic added the type: ERC label Dec 20, 2019

PaulRBerg force-pushed the feat/erc2212 branch from 5682e56 to daf43e7 Compare December 21, 2019 12:56

PaulRBerg force-pushed the feat/erc2212 branch from daf43e7 to db85761 Compare December 21, 2019 13:00

axic reviewed Dec 21, 2019

View reviewed changes

EIPS/eip-2212.md Outdated Show resolved Hide resolved

axic reviewed Dec 21, 2019

View reviewed changes

EIPS/eip-2212.md Show resolved Hide resolved

axic reviewed Dec 21, 2019

View reviewed changes

EIPS/eip-2212.md Outdated Show resolved Hide resolved

axic reviewed Dec 21, 2019

View reviewed changes

PaulRBerg added 2 commits September 8, 2020 14:02

Add eip-2212 markdown file

45f5bc8

Add reference to ERC-20 and cTokens

7c23143

PaulRBerg force-pushed the feat/erc2212 branch from 68ec16f to 7c23143 Compare September 8, 2020 11:02

Remove author email

1fc2fcd

axic reviewed Sep 8, 2020

View reviewed changes

EIPS/eip-2212.md Outdated Show resolved Hide resolved

axic reviewed Sep 8, 2020

View reviewed changes

fix: apply @axic's recommendations

fb1379d

PaulRBerg closed this Sep 9, 2020

PaulRBerg mentioned this pull request Sep 9, 2020

ERC-2212: Interest Earning Stakes #2212

Closed

PaulRBerg deleted the feat/erc2212 branch April 28, 2022 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ERC-2212 markdown #2444

Add ERC-2212 markdown #2444

PaulRBerg commented Dec 20, 2019

axic commented Dec 20, 2019

PaulRBerg commented Dec 21, 2019

axic Dec 21, 2019

PaulRBerg Dec 21, 2019 •

edited

Loading

axic Sep 7, 2020

PaulRBerg Sep 8, 2020

axic Sep 8, 2020

axic Dec 21, 2019

PaulRBerg Dec 21, 2019

PaulRBerg commented Jan 14, 2020

axic commented Sep 8, 2020

axic Sep 8, 2020

PaulRBerg Sep 9, 2020

axic Sep 9, 2020

PaulRBerg Sep 9, 2020

axic Sep 8, 2020

axic Sep 8, 2020

axic commented Sep 8, 2020

PaulRBerg commented Sep 9, 2020 •

edited

Loading

axic commented Sep 9, 2020

PaulRBerg commented Sep 9, 2020


		Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).

		@PaulRBerg and @SablierHQ.

Add ERC-2212 markdown #2444

Add ERC-2212 markdown #2444

Conversation

PaulRBerg commented Dec 20, 2019

axic commented Dec 20, 2019

PaulRBerg commented Dec 21, 2019

Choose a reason for hiding this comment

PaulRBerg Dec 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PaulRBerg commented Jan 14, 2020

axic commented Sep 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic commented Sep 8, 2020

PaulRBerg commented Sep 9, 2020 • edited Loading

axic commented Sep 9, 2020

PaulRBerg commented Sep 9, 2020

PaulRBerg Dec 21, 2019 •

edited

Loading

PaulRBerg commented Sep 9, 2020 •

edited

Loading