Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EIP5 as Superseded #1382

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Mark EIP5 as Superseded #1382

merged 3 commits into from
Sep 18, 2018

Conversation

axic
Copy link
Member

@axic axic commented Sep 4, 2018

Closes #8.

EIP211 states "replaces: 5".

EIP1 mandates:

Superseded – An EIP which was previously final but is no longer considered state-of-the-art. Another EIP will be in Final status and reference the Superseded EIP.

@axic
Copy link
Member Author

axic commented Sep 4, 2018

@Souptacular @Arachnid @nicksavers @gcolvin @cdetrio I think this makes sense, but it is the first example of applying these rules from EIP1.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 5 state from Draft to Superseded
  • EIP 5 requires approval from one of ([email protected])

@MicahZoltu
Copy link
Contributor

I thought there was discussion about getting rid of the Superseded state? If you want a new EIP, publish a new EIP. The old one is still a valid standard even if no one uses it anymore. e.g., HTTP 1 is still a valid standard even if virtually no one uses it and everyone uses HTTP 1.2.

@MicahZoltu
Copy link
Contributor

Note, this does get into the conversation about "where do we document what any given Ethereum chain implements in terms of core protocols. ETH and ETC implement a different set of EIPs, so I think putting this information in the EIP is the wrong place. However, there is value in making it easy for someone to identify what standards are implemented in any given chain.

@axic
Copy link
Member Author

axic commented Sep 5, 2018

EIP5 was merged at the time processes were entirely different. I don't think it was well discussed or peer reviewed. I'm not sure what would be the benefit not superseding it.

@Souptacular
Copy link
Contributor

I agree with @axic that at the time EIP5 was merged the processes were different and we need to make it known that it is superseded.

@Souptacular Souptacular merged commit fef63dc into ethereum:master Sep 18, 2018
@axic axic deleted the eip5 branch September 18, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants