-
Notifications
You must be signed in to change notification settings - Fork 6k
Update EIP-8024: Switch to branchless normalization and extend EXCHANGE #11306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @frangio :)
I have a question about the EXCHANGE depth check. If I understand correctly, the forbidden range implicitly ensures that
decode_pairalways producesn < m(with maxn = 14, maxm = 29). This invariant can be inferred from theencode_pairprecondition, but not as a postcondition ofdecode_pair. Since the depth check only validatesm, I believe it would be valuable for implementers to know thatdecode_pairalso guaranteesn < m, otherwisestack[top - n]could be an out-of-bounds access.Would it make sense to either change the depth check to be defensive
Or, since
decode_pairshould always producen < m, maybe add an assert to make the invariant explicit like inencode_pair?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, my mistake. I thought the diff showed you removing the assertion on the input
xrather than modifying it. So asserting the result seems unnecessary.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think there is an opportunity to make this clearer, though I prefer to keep the instruction spec as it is now. See #11351
By the way I realized with the new EXCHANGE it's much simpler to check whether a pair is swappable. Basically just
n + m <= 30.