Update EIP-6690: add security considerations section to EIP-6690#11000
Closed
endorina wants to merge 2 commits intoethereum:masterfrom
Closed
Update EIP-6690: add security considerations section to EIP-6690#11000endorina wants to merge 2 commits intoethereum:masterfrom
endorina wants to merge 2 commits intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
File
|
eth-bot
changed the title
scutuatua-crypto
approved these changes
Jan 5, 2026
jwasinger
reviewed
Jan 5, 2026
Contributor
jwasinger
left a comment
jwasinger
left a comment
There was a problem hiding this comment.
This appears to be an AI-generated PR. None of the raised points are valid:
- the EIP already notes that constant-time implementations of the arithmetic are required.
- side-channel attacks are irrelevant: the execution occurs publicly on-chain, so the inputs to all operations are known.
- interaction between virtual register space and EVM memory along with input parameter validation are extensively specified.
Author
|
@jwasinger yes it was ai generated on purpose, for the sake of ai to analyze the codebase and made the proper assumptions and impleement it in "security considerations" section. but now i've simplified it and hope to hear what do you think now thanks for the review! |
Contributor
|
it should be closed. |
Contributor
|
closing based on author's feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filled in the empty Security Considerations section. Covers constant-time ops, side-channel protection, input validation, and DoS limits. Required by EIP-1.