Update EIP-7612: fix basicdata version byte to ensure 32-byte header#10832
Open
Forostovec wants to merge 1 commit intoethereum:masterfrom
Open
Update EIP-7612: fix basicdata version byte to ensure 32-byte header#10832Forostovec wants to merge 1 commit intoethereum:masterfrom
Forostovec wants to merge 1 commit intoethereum:masterfrom
Conversation
Collaborator
File
|
Magken91
approved these changes
Nov 27, 2025
Magken91
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bytes(0) with a single zero byte for the account header version in verkle_set_account so that the assembled basicdata is exactly 32 bytes as specified in EIP-6800. The previous construction produced 31 bytes, shifting subsequent fields by one byte and breaking the documented offsets for code_size (5:8), nonce (8:16), and balance (16:32). Using b'\x00' restores the intended layout and keeps decoding in verkle_get_account consistent with the spec and with related documentation (EIP-6800 and the newer EIP-7864), without altering any other logic.