Skip to content

Conversation

@0xLogicalx
Copy link

drop the # <new_code> / # </new_code> placeholders from the apply_body, State, and set_storage snippets in EIPS/eip-7748.md, keep the examples focused on the actual code that should appear in implementations

@0xLogicalx 0xLogicalx requested a review from eth-bot as a code owner November 24, 2025 16:35
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Nov 24, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 24, 2025

File EIPS/eip-7748.md

Requires 1 more reviewers from @adietrichs, @g11tech, @gabrocheleau, @gballet, @GottfriedHerold, @jlokier, @jsign, @matkt, @parithosh, @tanishqjasoria

@eth-bot eth-bot added the a-review Waiting on author to review label Nov 24, 2025
@eth-bot eth-bot changed the title docs: remove leftover diff markers from eip-7748 examples Update EIP-7748: remove leftover diff markers from eip-7748 examples Nov 24, 2025
@g11tech
Copy link
Contributor

g11tech commented Dec 4, 2025

doesn't seem unreasonable to have these markers, so it depends on authors how they want to best highlight their EIP changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants