Update EIP-8024: Fix pair encoding to match intent#10704
Merged
eth-bot merged 2 commits intoethereum:masterfrom Nov 4, 2025
Merged
Update EIP-8024: Fix pair encoding to match intent#10704eth-bot merged 2 commits intoethereum:masterfrom
eth-bot merged 2 commits intoethereum:masterfrom
Conversation
github-actions
bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
eth-bot
previously approved these changes
Nov 4, 2025
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
auto-merge was automatically disabled
November 4, 2025 03:41
Head branch was pushed to by a user without write access
eth-bot
approved these changes
Nov 4, 2025
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the examples didn't match the spec. The example was more accurately reflecting my original intent (explained now in rationale), so I've modified the decoding/encoding functions to match that.