-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add EIP: Precompile for ML-DSA signature verification #10557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Merge ethereum eips
File
|
EIPS/eip-8051.md
Outdated
|
|
||
| ## Reference Implementation | ||
|
|
||
| An implementation is provided in `assets` of this EIP. For the NIST-compliant version, KAT vectors of the NIST submission are valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamWilsn how best to handle reference implementation, again we have code attached in assets. How can we let people refer to full working code implementations?
@simonmasson instead of having full code attached, we prefer if you showcase the implementation through high level concepts/pseudo code instead of trying to attach a full working code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at bls12 eip, which face similar problems, would test vectors be enough ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@g11tech how would you feel if they cut down the reference implementation to just the bare minimum required to showcase the EIP? There does seem to be a lot of extra stuff in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that will work, also what about testvectors, some of them are/could be huge files (as in some other EIPs as well)
@rdubois-crypto its for you to best decide how to succinctly represent your EIP so yes that could work but again if its a limited amount of vectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the python code, and provide now only the KAT vectors, and solidity tests in Solidity.
|
The commit 7747dfe (as a parent of 1eec3db) contains errors. |
g11tech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix the issues flagged by the bot
This proposal creates a two contracts for:
This enables post-quantum secure signatures for Ethereum.