Skip to content

Conversation

@simonmasson
Copy link
Contributor

This proposal creates a two contracts for:

  • Verifying a ML-DSA (FIPS-204 standard) signature
  • Verifying a ML-DSA-ETH signature (where the hash function has a lower gas cost).

This enables post-quantum secure signatures for Ethereum.

@simonmasson simonmasson requested a review from eth-bot as a code owner October 17, 2025 08:35
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 17, 2025

File EIPS/eip-8051.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core w-ci Waiting on CI to pass labels Oct 17, 2025
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 17, 2025
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 20, 2025
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Oct 20, 2025
EIPS/eip-8051.md Outdated

## Reference Implementation

An implementation is provided in `assets` of this EIP. For the NIST-compliant version, KAT vectors of the NIST submission are valid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamWilsn how best to handle reference implementation, again we have code attached in assets. How can we let people refer to full working code implementations?

@simonmasson instead of having full code attached, we prefer if you showcase the implementation through high level concepts/pseudo code instead of trying to attach a full working code

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at bls12 eip, which face similar problems, would test vectors be enough ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g11tech how would you feel if they cut down the reference implementation to just the bare minimum required to showcase the EIP? There does seem to be a lot of extra stuff in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that will work, also what about testvectors, some of them are/could be huge files (as in some other EIPs as well)

@rdubois-crypto its for you to best decide how to succinctly represent your EIP so yes that could work but again if its a limited amount of vectors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the python code, and provide now only the KAT vectors, and solidity tests in Solidity.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 14, 2025
@github-actions
Copy link

The commit 7747dfe (as a parent of 1eec3db) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 15, 2025
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the issues flagged by the bot

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants