-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add EIP: FOCIL with ranked transactions (FOCILR) #10554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All reviewers have approved. |
7e6065c to
0e8c699
Compare
0e8c699 to
7f52250
Compare
4847d2b to
5901959
Compare
|
The commit 5901959 (as a parent of 3d34007) contains errors. |
123ae12 to
ec3d83f
Compare
|
|
||
| ```Python | ||
| # TODO: To be defined after scheduling this EIP relative to EIP-7999 and EIP-8011, etc. | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a html <-- TODO --> marker here for bot to help you flag when moving past draft stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
EIPS/eip-8046.md
Outdated
|
|
||
| ### Altered FOCIL post-execution inclusion check | ||
|
|
||
| The post-execution inclusion check of EIP-7805 is altered as outlined in the figure. Orange squares represent the original FOCIL checks, where "No" always leads to jumping to the next transaction. Blue squares are the checks added in FOCILR that account for ranking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend to ref to EIP 7805 as a link, which is generally handy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was linked previously but added links for all repeated EIP references throughout the document now.
|
|
||
| ----- | ||
|
|
||
| The original step (1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also include step 1 in your comparison image for the sake of completeness, so that references to step 1 are clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks that's good advice! I updated the figure now.
EIPS/eip-8046.md
Outdated
|
|
||
| There are nuances to the design that need careful consideration before adoption. Something to be attentive to is the effect of burning the marginal ranking fee, given that avoiding the burn is not a zero-sum outcome for builders and includers. This is further discussed in the next section. | ||
|
|
||
| ### Alternative designs for rewarding includers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move alternative designs to spec heading, not sure if this all belongs in a Rationale heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed headings
eth-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
No description provided.