Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chain id argument and support for multiple chains in state.json #933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Mar 7, 2025

This modifies the justfile and create_config command to optionally accept a chain id. This is useful in cases where there are more than one L2 in the state.json file.

Making the command optional should ensure that the change is non breaking for users.

@maurelian maurelian requested a review from a team as a code owner March 7, 2025 17:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (08e3fe4) to head (adc53e5).

Files with missing lines Patch % Lines
ops/internal/manage/staging.go 0.00% 21 Missing ⚠️
ops/cmd/create_config/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   43.49%   43.02%   -0.47%     
==========================================
  Files          39       39              
  Lines        2297     2322      +25     
==========================================
  Hits          999      999              
- Misses       1210     1235      +25     
  Partials       88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants