Merged
Conversation
7f6c011 to
23b7831
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 39 39
Lines 2297 2297
=======================================
Hits 999 999
Misses 1210 1210
Partials 88 88 ☔ View full report in Codecov by Sentry. |
maurelian
reviewed
Feb 27, 2025
Contributor
maurelian
left a comment
There was a problem hiding this comment.
Could we add a test that:
- get the OPCM address
- calls
opcm.implementations() - ensures that all contracts and versions in the release match the returned struct and versions
Co-authored-by: Maurelian <john@oplabs.co>
maurelian
approved these changes
Feb 27, 2025
Contributor
maurelian
left a comment
There was a problem hiding this comment.
Thanks for adding the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses can be verified by comparing the implementations on Etherscan to what's included here. OP Deployer bootstrap output is below:
Input: