Skip to content

Add Sepolia v2.0.0-rc.1 versions#920

Merged
mslipper merged 7 commits intomainfrom
feat/v200-sepolia-versions
Feb 27, 2025
Merged

Add Sepolia v2.0.0-rc.1 versions#920
mslipper merged 7 commits intomainfrom
feat/v200-sepolia-versions

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Feb 26, 2025

Addresses can be verified by comparing the implementations on Etherscan to what's included here. OP Deployer bootstrap output is below:

INFO [02-26|16:40:13.575] transaction confirmed                    id=57fd8d..84e384 completed=1 total=1 hash=0x3240eae895ad2a89f83f6af7bed3e9717a2d82074ac8c044e30c109719cbfe71 nonce=0 creation=0x0000000000000000000000000000000000000000
INFO [02-26|16:40:13.575] deployed implementations
{
  "Opcm": "0x1b25f566336f47bc5e0036d66e142237dcf4640b",
  "DelayedWETHImpl": "0x5e40b9231b86984b5150507046e354dbfbed3d9e",
  "OptimismPortalImpl": "0x2d7e764a0d9919e16983a46595cfa81fc34fa7cd",
  "PreimageOracleSingleton": "0x1fb8cdfc6831fc866ed9c51af8817da5c287add3",
  "MipsSingleton": "0xaa59a0777648bc75cd10364083e878c1ccd6112a",
  "SystemConfigImpl": "0x760c48c62a85045a6b69f07f4a9f22868659cbcc",
  "L1CrossDomainMessengerImpl": "0x3ea6084748ed1b2a9b5d4426181f1ad8c93f6231",
  "L1ERC721BridgeImpl": "0x276d3730f219f7ec22274f7263180b8452b46d47",
  "L1StandardBridgeImpl": "0x78972e88ab8bbb517a36caea23b931bab58ad3c6",
  "OptimismMintableERC20FactoryImpl": "0x5493f4677a186f64805fe7317d6993ba4863988f",
  "DisputeGameFactoryImpl": "0x4bba758f006ef09402ef31724203f316ab74e4a0",
  "AnchorStateRegistryImpl": "0x7b465370bb7a333f99edd19599eb7fb1c2d3f8d2",
  "SuperchainConfigImpl": "0x4da82a327773965b8d4d85fa3db8249b387458e7",
  "ProtocolVersionsImpl": "0x37e15e4d6dffa9e5e320ee1ec036922e563cb76c"
}

Input:

op-deployer bootstrap implementations --artifacts-locator tag://op-contracts/v2.0.0-rc.1 --l1-contracts-release op-contracts/v2.0.0 --l1-rpc-url $SEPOLIA_RPC_URL --mips-version 1 --private-key $PRIVATE_KEY_SEPOLIA --protocol-versions-proxy 0x79ADD5713B383DAa0a138d3C4780C7A1804a8090 --superchain-config-proxy 0xC2Be75506d5724086DEB7245bd260Cc9753911Be --upgrade-controller 0x1Eb2fFc903729a0F03966B917003800b145F56E2

@mslipper mslipper requested a review from a team as a code owner February 26, 2025 23:42
@mslipper mslipper force-pushed the feat/v200-sepolia-versions branch from 7f6c011 to 23b7831 Compare February 26, 2025 23:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.49%. Comparing base (eda352a) to head (fb51023).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   43.49%   43.49%           
=======================================
  Files          39       39           
  Lines        2297     2297           
=======================================
  Hits          999      999           
  Misses       1210     1210           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test that:

  1. get the OPCM address
  2. calls opcm.implementations()
  3. ensures that all contracts and versions in the release match the returned struct and versions

Comment thread validation/standard/standard-versions-sepolia.toml Outdated
Comment thread validation/standard/standard-versions-sepolia.toml Outdated
Comment thread validation/standard/standard-versions-sepolia.toml Outdated
Comment thread validation/standard/standard-versions-sepolia.toml Outdated
Comment thread validation/standard/standard-versions-sepolia.toml Outdated
Comment thread validation/standard/standard-versions-sepolia.toml
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@mslipper mslipper added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit b4f7e40 Feb 27, 2025
@mslipper mslipper deleted the feat/v200-sepolia-versions branch February 27, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants