fix gas-token_test #522
Merged
fix gas-token_test #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open question whether we should be storing the default (ether) gas paying token in the chain configs. We could store nothing when we detect ether as the gas paying token. |
geoknee
force-pushed
the
gk/gas-token-bug
branch
from
9e43d68 to
155c592
Compare
geoknee
force-pushed
the
gk/gas-token-bug
branch
from
155c592 to
3b4ba67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, we aren't dealing with 32 byte hex string encoded boolean return values.