Skip to content

Finalize Upgrade #4 status #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maurelian merged 2 commits into from
Feb 22, 2024
Merged

Finalize Upgrade #4 status #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e8024
Finalize Upgrade #4 status
maurelian Feb 22, 2024
c152b36
Add non-veto reference link
maurelian Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tasks/eth/3-add-superchainConfig/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Upgrade #4 Multisig Ceremony

Status: DRAFT, NOT READY TO SIGN

> [!IMPORTANT] !!! DO NOT SIGN using this playbook yet, as the associated governance proposal has
> not yet passed.
Status: READY_TO_SIGN

## Objective

This is the playbook for executing Upgrade #4, pending approval by governance. Voting on this
proposal is tracked at https://vote.optimism.io/proposals/tbd.
This is the playbook for executing Upgrade #4.

The proposal was:
- [X] approved by Token House voting here: https://vote.optimism.io/proposals/110376471005925230990107796624328147348746431603727026291575353089698990280147
- [X] not vetoed by the Citizens' house here: https://snapshot.org/#/citizenshouse.eth/proposal/0x9e85524badfcec19856bfc51cfefc78cb5f36a9b77ec0b3b304d7d7768bdf810

The proposal should be treated as the source of truth and used by the multisig signers to verify the
correctness of the onchain operations.
Expand Down
8 changes: 4 additions & 4 deletions tasks/eth/3-add-superchainConfig/Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ Enables the simulation by reducing the threshold to 1:
The Safe you are signing for will have the following overrides which will set the [Multicall](https://etherscan.io/address/0xca11bde05977b3631167028862be2a173976ca11#code) contract as the sole owner of the signing safe. This allows simulating both the approve hash and the final tx in a single Tenderly tx.

- **Key:** 0x0000000000000000000000000000000000000000000000000000000000000003 <br/>
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001 <br/>
**Meaning:** The number of owners is set to 1.

- **Key:** 0x0000000000000000000000000000000000000000000000000000000000000004 <br/>
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001 <br/>
**Meaning:** The threshold is set to 1.

The following two overrides are modifications to the [`owners` mapping](https://github.com/safe-global/safe-contracts/blob/v1.4.0/contracts/libraries/SafeStorage.sol#L15). For the purpose of calculating the storage, note that this mapping is in slot `2`.
Expand All @@ -49,13 +49,13 @@ This mapping implements a linked list for iterating through the list of owners.
And we do indeed see these entries:

- **Key:** 0x316a0aac0d94f5824f0b66f5bbe94a8c360a17699a1d3a233aafcf7146e9f11c <br/>
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001
**Value:** 0x0000000000000000000000000000000000000000000000000000000000000001 <br/>
**Meaning:** This is `owners[0xca11bde05977b3631167028862be2a173976ca11] -> 1`, so the key can be
derived from `cast index address 0xca11bde05977b3631167028862be2a173976ca11 2`.


- **Key:** 0xe90b7bceb6e7df5418fb78d8ee546e97c83a08bbccc01a0644d599ccd2a7c2e0 <br/>
**Value:** 0x000000000000000000000000ca11bde05977b3631167028862be2a173976ca11
**Value:** 0x000000000000000000000000ca11bde05977b3631167028862be2a173976ca11 <br/>
**Meaning:** This is `owners[1] -> 0xca11bde05977b3631167028862be2a173976ca11`, so the key can be
derived from `cast index address 0x0000000000000000000000000000000000000001 2`.

Expand Down