Conversation
clabby
left a comment
There was a problem hiding this comment.
Nicely done. Ran through the simulation and checked the deployments, looks good to me.
…SignFromJson.s.sol Co-authored-by: clabby <ben@clab.by>
clabby
left a comment
There was a problem hiding this comment.
re-approval after the suggestion was added
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
|
Hey @sebastianst @geoknee, anything blocking getting the comments here addressed to get this PR merged? |
@mds1 I'll work on it this week. I am going to do a major refactor to create a validation template for the FP upgrade, so we don't need to copy-paste the validations for the sepolia fp upgrade fix and mainnet fp upgrade. |
|
Agreed with @mds1 that remaining open discussion items will be addressed in the follow up task to fix the Sepolia FPs with the correct |
There was a problem hiding this comment.
Approving per #374 (comment), this was executed successfully and comments will be addressed for future playbooks. We should also add a postCheck that reads the weth address from the dispute games, call it's version() method, and ensure the result is 1.1.0 (per https://github.com/ethereum-optimism/superchain-registry/blob/564649664d4ebfddf2a8b17b6a84e1af7b774edc/validation/standard/standard-versions-mainnet.toml#L13)
Description
OP Sepolia Holocene FP upgrade - sets new FDG and PDG implementations.
Tests
Verifications added for the new DGs, and correct MIPS vm.
Towards ethereum-optimism/optimism#13033