-
Notifications
You must be signed in to change notification settings - Fork 128
feat: add devnet task (#110) #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a0afaf0
b13271c
3978503
7a374ff
cea7313
11e87fe
943b3e1
0d7ad92
f2ef401
d258ab1
346ce2e
4683981
a828309
d7ce71a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # 049-rev-share-betanet: RevShare Upgrade and Setup for Betanet | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we gonna need to change the number here too? |
||
|
|
||
| Status: [READY TO SIGN] | ||
|
|
||
| ## Objective | ||
|
|
||
| Upgrade proxies and setup RevShare contracts for the RevShare Betanet chain. This task: | ||
|
|
||
| 1. Deploys all needed contract implementations: | ||
| - FeeVaults | ||
| - FeeSplitter | ||
| - L1Withdrawer (pointing to the FeesDepositor on L1) | ||
| - RevShareCalculator (pointing to the L1Withdrawer and the ChainFeesRecipient) | ||
| 2. Upgrades the fee vault proxy implementations (SequencerFeeVault, BaseFeeVault, L1FeeVault, OperatorFeeVault) on the Betanet L2 | ||
| 3. Sets FeeSplitter predeploy to point to the new FeeSplitter implementation and initializes it with the RevShareCalculator address | ||
|
|
||
| Target chain: | ||
|
|
||
| - revshare-beta-0 (chainId: 420120033) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this change once we have the new betanet? ethereum-optimism/devnets#248 cc @maurelian
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IDK tbh. But we should probably hold off on merging this until we do know. |
||
|
|
||
| ## Simulation & Signing | ||
|
|
||
| Simulation commands for each safe: | ||
|
|
||
| ```bash | ||
| # For stacked simulation (recommended for validation): | ||
| just simulate-stack sep 049-rev-share-betanet <council|foundation> | ||
|
|
||
| # For individual simulation: | ||
| cd src/tasks/sep/049-rev-share-betanet | ||
| SIMULATE_WITHOUT_LEDGER=1 just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile simulate <council|foundation> | ||
| ``` | ||
|
|
||
| Signing commands for each safe: | ||
|
|
||
| ```bash | ||
| cd src/tasks/sep/049-rev-share-betanet | ||
| just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile sign <council|foundation> | ||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Validation | ||
|
|
||
| This document can be used to validate the inputs and result of the execution of the upgrade transaction which you are | ||
| signing. | ||
|
|
||
| ## Expected Domain and Message Hashes | ||
|
|
||
| Validate the domain and message hashes. These values should match both the values on your ledger and | ||
| the values printed to the terminal when you run the task. | ||
|
|
||
| > [!CAUTION] | ||
| > | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Nested Safe 1 (Foundation): `0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B` | ||
| > | ||
| > - Domain Hash: `0x37e1f5dd3b92a004a23589b741196c8a214629d4ea3a690ec8e41ae45c689cbb` | ||
| > - Message Hash: `0x48875a3a381e995496f156badf1b1502ac5f185d4d443d1584208a792f505a9a` | ||
| > | ||
| > ### Nested Safe 2 (Security Council): `0xf64bc17485f0B4Ea5F06A96514182FC4cB561977` | ||
| > | ||
| > - Domain Hash: `0xbe081970e9fc104bd1ea27e375cd21ec7bb1eec56bfe43347c3e36c5d27b8533` | ||
| > - Message Hash: `0x96f45cbc005f87ecd5e71c20849cf0e5a872794d19d21ac6ba77732475069d1c` | ||
|
|
||
| ## Task Calldata | ||
|
|
||
| ``` | ||
| 0x82ad56cb00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000071241bbae674967dd523e621c272ea32cf33119a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000e41a80dc3800000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000a1f4f424901e0773e68c714077bcdd5cf8bcec230000000000000000000000000000000000000000000000001bc16d674ec80000000000000000000000000000ed9b99a703bad32ac96fddc313c0652e379251fd00000000000000000000000000000000000000000000000000000000000c35000000000000000000000000005f077b4c3509c2c192e50b6654d924fcb8126a6000000000000000000000000000000000000000000000000000000000 | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "420120033": { | ||
| "ProxyAdminOwner": "0x1eb2ffc903729a0f03966b917003800b145f56e2" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # RevShare Upgrade And Setup Configuration | ||
|
|
||
| templateName = "RevShareUpgradeAndSetup" | ||
|
|
||
| # L2 chains to target | ||
| l2chains = [{name = "revshare-beta-0", chainId = 420120033}] | ||
|
|
||
| safeAddress = "ProxyAdminOwner" | ||
|
|
||
| # RevShareContractsUpgrader address | ||
| revShareUpgrader = "0x71241bbae674967dd523e621c272ea32cf33119a" | ||
|
|
||
| # RevShare configurations (one per chain) - flattened arrays | ||
| portals = ["0xa1F4F424901e0773e68C714077bCDD5CF8BcEc23"] | ||
|
|
||
| chainFeesRecipients = ["0x5f077b4c3509C2c192e50B6654d924Fcb8126A60"] | ||
|
|
||
| # 2 ether | ||
| l1WithdrawerMinWithdrawalAmounts = [2000000000000000000] | ||
|
|
||
| # FeesDepositor address in mainnet | ||
| l1WithdrawerRecipients = ["0xed9B99a703BaD32AC96FDdc313c0652e379251Fd"] | ||
| l1WithdrawerGasLimits = [800000] | ||
|
|
||
| fallbackAddressesJsonPath = "src/tasks/sep/049-rev-share-betanet/addresses.json" | ||
|
|
||
| [addresses] | ||
| ProxyAdminOwner = "0x1eb2ffc903729a0f03966b917003800b145f56e2" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| TENDERLY_GAS=16700000 |
Uh oh!
There was an error while loading. Please reload this page.