U18 Betanet tasks#1319
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "420110022": { | |||
There was a problem hiding this comment.
From the directory, it's not clear which betanet and chain in https://github.com/ethereum-optimism/devnets/tree/main/betanets this folder refers to.
From the chain ID key it seems that https://github.com/ethereum-optimism/devnets/blob/f48b318e8f8ee70bc1b60ce31dd3ad20240f2c1a/betanets/u18-beta/u18-beta-1/chain.yaml is the chain, but the address in that file don't match what's in this file
| "L1StandardBridgeProxy": "0x3756BF0380E7fdABcB81f2cFb1d8022e8B798a8F", | ||
| "OptimismPortalProxy": "0xbd36ac8fB65F192dAEbCB2Dca819CB7ea7D60417", | ||
| "DisputeGameFactoryProxy": "0x298038f9E37b370d20E58706E8Ac78475b089FB2", | ||
| "DelayedWETHProxy": "0x62841F5E03a56f818BC8818c5130757acA2541A7", |
There was a problem hiding this comment.
Do we need this? Chains have multiple DelayedWETHs so we should delete this and "discover" DelayedWETH addrs when needed via contract calls
| ] | ||
|
|
||
| [[configs]] | ||
| # The below addresses can be found here https://github.com/ethereum-optimism/devnets/blob/main/betanets/u18-beta/u18-beta-1/chain.yaml |
There was a problem hiding this comment.
Why do we have to define the addresses here, if they are also in addresses.json? It would be great if we can remove them from here. And similar to above the addresses still don't match. For example this file has a systemConfig of 0x5babF93aC7AFfeaE25dc1a7ad4587fDeEbba44C2 but the linked file shows it as 0x4E0528A9dc40FEdf1C2cFc0eAA04e70E7d3d591B
| proxyAdmin = "0xcd18a0C04286Eba52Bb168Fa1D79133Da4856bEf" | ||
| delayedWETH = "0x62841F5E03a56f818BC8818c5130757acA2541A7" | ||
| disputeGameType = 0 | ||
| disputeAbsolutePrestate = "0x03ccb5619628eeba89d58b204aadeb2ed9f51d18ff938069dd298b9e19fb2d31" # Source: https://www.notion.so/oplabs/Betanet-2a9f153ee16280859261e3000d866ee9?source=copy_link#2c5f153ee1628012bc4dfbeaae710c70 |
There was a problem hiding this comment.
Can we link to an official prestate review as evidence this is correct instead? This link shows me the prestate was generated on Dec 10, but how do we know that Dec 10 generated the right prestate?
| disputeClockExtension = 10800 | ||
| disputeMaxClockDuration = 302400 | ||
| initialBond = 80000000000000000 | ||
| vm = "0x6463dEE3828677F6270d83d45408044fc5eDB908" # Source: https://github.com/ethereum-optimism/superchain-registry/blob/ad5becd08007b80988679b8f0c08d415e1294066/validation/standard/standard-versions-sepolia.toml#L11 |
There was a problem hiding this comment.
Why are we hardcoding a vm address as input? This seems suspect. Can we e.g. read it from OPCM instead? The template has an OPCM var, but also takes this as an input, which seems redundant. Maybe a question for proofs team
|
|
||
| ## Objective | ||
|
|
||
| This task adds the dispute game type 0 (Permissionless) to the Dispute Game Factory on OP Betanet for U18. |
There was a problem hiding this comment.
Does op-deployer not support configuring permissionless games when the chain is stood up? I thought it did
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "420110022": { | |||
There was a problem hiding this comment.
Similar to above comment, addresses in this file don't match what's in https://github.com/ethereum-optimism/devnets/blob/main/betanets/u18-beta/u18-beta-1/chain.yaml
| > | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Betanet Proxy Admin Owner (`0xe934Dc97E347C6aCef74364B50125bb8689c40ff`) |
There was a problem hiding this comment.
Is there a way to verify this in https://github.com/ethereum-optimism/devnets/blob/main/betanets/u18-beta/u18-beta-1/chain.yaml? Seems like the PAO is not listed there
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "420110021": { | |||
There was a problem hiding this comment.
Addresses don't match from https://github.com/ethereum-optimism/devnets/blob/f48b318e8f8ee70bc1b60ce31dd3ad20240f2c1a/betanets/u18-beta/u18-beta-0/chain.yaml — how can we have caught all of these mismatches in CI instead of requiring manual review. Let's aim to shift left here
| # U18 prestates from betanet: https://www.notion.so/oplabs/Betanet-2a9f153ee16280859261e3000d866ee9?source=copy_link#2c5f153ee162805abcc3e949ab6c837e | ||
| cannonPrestate = "0x03f833cc2a644a9f7bba9718c13f622b867c513f3c43f3eb5a0cad17784bd408" | ||
| cannonKonaPrestate = "0x03845751c66672c0b09e68ba7c3024a7543a1a22edaa90d7c2c90ebc8cecee68" |
There was a problem hiding this comment.
Similar prestate questions for this file as above
|
Leaving this comment for tracking: the betanets were redeployed, this is why the addresses do not match @mds1. I will update the addresses so they are referring to the correct betanet. |
3 participants
This PR add the below tasks necessary for U18 on OP betanets: