-
Notifications
You must be signed in to change notification settings - Fork 128
feat: production configs #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maurelian
merged 29 commits into
ethereum-optimism:main
from
defi-wonderland:sc-feat/production-configs
Dec 18, 2025
Merged
feat: production configs #1318
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
41074ad
test: update configs with soneium (#81)
0xChin 1561a44
fix: forge fmt (#84)
0xChin a4606e8
Merge branch 'main' into sc-feat/configs-update
0xDiscotech a39d229
Merge branch 'main' into chore/sync-main
0xChin 0323300
Merge branch 'main' into chore/sync-main
0xChin 1ab812b
Merge pull request #87 from defi-wonderland/chore/sync-main
0xDiscotech 61863c8
fix: build error (#88)
0xChin b3feacd
fix: warning
0xDiscotech b0b425b
chore: sync prod configs (#94)
0xChin 8f64339
chore: update tasks config values
0xChin 2a87370
Merge branch 'main' into chore/sync-prod-configs
0xChin 9a16ce0
fix: remove wrong config
0xChin e0695de
Merge pull request #97 from defi-wonderland/chore/sync-prod-configs
0xDiscotech 1cbc138
feat: add production task (#98)
0xChin 9ebf89d
Merge branch 'main' into chore/sync-and-fusaka-blocks
0xChin 1e23feb
test: use fusaka block numbers and update regression tests
0xChin cece3da
fix: sep task order on name
0xDiscotech 9d73dcb
Merge pull request #99 from defi-wonderland/chore/sync-and-fusaka-blocks
0xDiscotech 55f0e45
fix: integration and stack simulate tests (#100)
0xDiscotech 294dfb1
Merge branch 'main' into chore/sync-prod-configs
0xChin eff68e1
fix: update message hashes
0xDiscotech a44782d
fix: reduce upgrade gas limit (#102)
0xChin 7228ff8
chore: update gas limit on examples as well
0xDiscotech 8e57372
Merge pull request #101 from defi-wonderland/chore/sync-prod-configs
0xDiscotech 7ab25a3
fix: sep council msg hash based on stacked simulation (#103)
0xDiscotech 825301e
fix: add nonce overrides in sepolia task, fix hash in eth task (#106)
0xChin fd7c738
fix: remove pao nonce update on 048 and msg hashes (#107)
0xDiscotech cc21765
Merge branch 'main' into chore/sync-prod-configs-3
0xChin 7cfbd99
Merge pull request #108 from defi-wonderland/chore/sync-prod-configs-3
0xDiscotech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| TENDERLY_GAS=16700000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # 037-rev-share-ink-soneium: RevShare Upgrade and Setup for Ink and Soneium Mainnets | ||
|
|
||
| Status: [DRAFT, NOT READY TO SIGN]() | ||
|
|
||
| ## Objective | ||
|
|
||
| Upgrade proxies and setup RevShare contracts for Ink and Soneium Mainnets. This task: | ||
|
|
||
| 1. Deploys all needed contract implementations: | ||
| - FeeVaults | ||
| - FeeSplitter | ||
| - L1Withdrawer (pointing to the FeesDepositor on L1) | ||
| - RevShareCalculator (pointing to the L1Withdrawer and the ChainFeesRecipient) | ||
| 2. Upgrades the fee vault proxy implementations (SequencerFeeVault, BaseFeeVault, L1FeeVault, OperatorFeeVault) on Ink and Soneium L2s | ||
| 3. Sets FeeSplitter predeploy to point to the new FeeSplitter implementation and initializes it with the RevShareCalculator address | ||
|
|
||
| Target chains: | ||
|
|
||
| - Ink Mainnet (chainId: 57073) | ||
| - Soneium Mainnet (chainId: 1868) | ||
|
|
||
| ## Simulation & Signing | ||
|
|
||
| Simulation commands for each safe: | ||
|
|
||
| ```bash | ||
| cd src/tasks/eth/037-rev-share-ink-soneium | ||
| SIMULATE_WITHOUT_LEDGER=1 just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile simulate <council|foundation> | ||
| ``` | ||
|
|
||
| Signing commands for each safe: | ||
|
|
||
| ```bash | ||
| cd src/tasks/eth/037-rev-share-ink-soneium | ||
| SIMULATE_WITHOUT_LEDGER=1 just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile sign <council|foundation> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Validation | ||
|
|
||
| This document can be used to validate the inputs and result of the execution of the upgrade transaction which you are | ||
| signing. | ||
|
|
||
| ## Expected Domain and Message Hashes | ||
|
|
||
| Validate the domain and message hashes. These values should match both the values on your ledger and | ||
| the values printed to the terminal when you run the task. | ||
|
|
||
| > [!CAUTION] | ||
| > | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Nested Safe 1 (Foundation): `0x847B5c174615B1B7fDF770882256e2D3E95b9D92` | ||
| > | ||
| > - Domain Hash: `0xa4a9c312badf3fcaa05eafe5dc9bee8bd9316c78ee8b0bebe3115bb21b732672` | ||
| > - Message Hash: `0x54ce340c4739a7b821abc9a4d1fc553ef3eab9af2a4f6d6cd8b029e254050c0f` | ||
| > | ||
| > ### Nested Safe 2 (Security Council): `0xc2819DC788505Aac350142A7A707BF9D03E3Bd03` | ||
| > | ||
| > - Domain Hash: `0xdf53d510b56e539b90b369ef08fce3631020fbf921e3136ea5f8747c20bce967` | ||
| > - Message Hash: `0xddd5bfdade4e3e69c2a1055039c1f159b6fc48e52a21206cbaf0828ec7f06008` | ||
|
|
||
| ## Task Calldata | ||
|
|
||
| ``` | ||
| 0x82ad56cb00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000071241bbae674967dd523e621c272ea32cf33119a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000001841a80dc38000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000020000000000000000000000005d66c1782664115999c47c9fa5cd031f495d3e4f0000000000000000000000000000000000000000000000001bc16d674ec80000000000000000000000000000ed9b99a703bad32ac96fddc313c0652e379251fd00000000000000000000000000000000000000000000000000000000000c35000000000000000000000000005f077b4c3509c2c192e50b6654d924fcb8126a6000000000000000000000000088e529a6ccd302c948689cd5156c83d4614fae920000000000000000000000000000000000000000000000001bc16d674ec80000000000000000000000000000ed9b99a703bad32ac96fddc313c0652e379251fd00000000000000000000000000000000000000000000000000000000000c3500000000000000000000000000f07b3169fff67a8aecdbb18d9761aeee3459111200000000000000000000000000000000000000000000000000000000 | ||
| ``` |
|
maurelian marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # RevShare Upgrade And Setup Configuration | ||
|
|
||
| templateName = "RevShareUpgradeAndSetup" | ||
|
|
||
| # L2 chains to target | ||
| l2chains = [{name = "Ink", chainId = 57073}, {name = "Soneium", chainId = 1868}] | ||
|
|
||
| safeAddress = "ProxyAdminOwner" | ||
|
|
||
| # RevShareContractsUpgrader address | ||
| revShareUpgrader = "0x71241bbae674967dd523e621c272ea32cf33119a" | ||
|
|
||
| # RevShare configurations (one per chain) - flattened arrays | ||
| portals = [ | ||
| "0x5d66C1782664115999C47c9fA5cd031f495D3e4F", # Ink Mainnet Portal | ||
| "0x88e529A6ccd302c948689Cd5156C83D4614FAE92" # Soneium Mainnet Portal | ||
| ] | ||
|
|
||
| chainFeesRecipients = [ | ||
| "0x5f077b4c3509C2c192e50B6654d924Fcb8126A60", # L1Withdrawer to send funds in Mainnet to address 0xa6f0F94C13C4255231958079E7331694205F6c93 | ||
| "0xF07b3169ffF67A8AECdBb18d9761AEeE34591112" | ||
|
maurelian marked this conversation as resolved.
|
||
| ] | ||
|
|
||
| # 2 ether | ||
| l1WithdrawerMinWithdrawalAmounts = [2000000000000000000, 2000000000000000000] | ||
|
|
||
| # FeesDepositor address in mainnet | ||
| l1WithdrawerRecipients = [ | ||
| "0xed9B99a703BaD32AC96FDdc313c0652e379251Fd", | ||
| "0xed9B99a703BaD32AC96FDdc313c0652e379251Fd" | ||
| ] | ||
| l1WithdrawerGasLimits = [800000, 800000] | ||
|
|
||
| [addresses] | ||
| ProxyAdminOwner = "0x5a0Aae59D09fccBdDb6C6CcEB07B7279367C3d2A" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| TENDERLY_GAS=16700000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # 049-rev-share-ink-soneium: RevShare Upgrade and Setup for Ink Sepolia and Soneium Minato | ||
|
|
||
| Status: [DRAFT, NOT READY TO SIGN]() | ||
|
|
||
| ## Objective | ||
|
|
||
| Upgrade proxies and setup RevShare contracts for Ink Sepolia and Soneium Testnet Minato. This task: | ||
|
|
||
| 1. Deploys all needed contract implementations: | ||
| - FeeVaults | ||
| - FeeSplitter | ||
| - L1Withdrawer (pointing to the FeesDepositor on L1) | ||
| - RevShareCalculator (pointing to the L1Withdrawer and the ChainFeesRecipient) | ||
| 2. Upgrades the fee vault proxy implementations (SequencerFeeVault, BaseFeeVault, L1FeeVault, OperatorFeeVault) on Ink Sepolia and Soneium Minato L2s | ||
| 3. Sets FeeSplitter predeploy to point to the new FeeSplitter implementation and initializes it with the RevShareCalculator address | ||
|
|
||
| Target chains: | ||
|
|
||
| - Ink Sepolia (chainId: 763373) | ||
| - Soneium Testnet Minato (chainId: 1946) | ||
|
|
||
| ## Simulation & Signing | ||
|
|
||
| > **Note:** This task depends on prior tasks in the Sepolia stack (047, 048). The hashes in VALIDATION.md | ||
| > were generated using `simulate-stack` which simulates all tasks in sequence. Running `simulate` individually | ||
| > may show different hashes because it doesn't account for nonce increments from prior tasks. | ||
|
|
||
| Simulation commands for each safe: | ||
|
|
||
| ```bash | ||
| # For stacked simulation (recommended for validation): | ||
| just simulate-stack sep 049-rev-share-ink-soneium <council|foundation> | ||
|
|
||
| # For individual simulation: | ||
| cd src/tasks/sep/049-rev-share-ink-soneium | ||
| SIMULATE_WITHOUT_LEDGER=1 just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile simulate <council|foundation> | ||
| ``` | ||
|
|
||
| Signing commands for each safe: | ||
|
|
||
| ```bash | ||
| cd src/tasks/sep/049-rev-share-ink-soneium | ||
| just --dotenv-path "$(pwd)"/.env --justfile ../../../justfile sign <council|foundation> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Validation | ||
|
|
||
| This document can be used to validate the inputs and result of the execution of the upgrade transaction which you are | ||
| signing. | ||
|
|
||
| ## Expected Domain and Message Hashes | ||
|
|
||
| Validate the domain and message hashes. These values should match both the values on your ledger and | ||
| the values printed to the terminal when you run the task. | ||
|
|
||
| > [!CAUTION] | ||
| > | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Nested Safe 1 (Foundation): `0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B` | ||
| > | ||
| > - Domain Hash: `0x37e1f5dd3b92a004a23589b741196c8a214629d4ea3a690ec8e41ae45c689cbb` | ||
| > - Message Hash: `0x525fe8644760f20a75f3e4b4e33f7e980d3c16270a1aa01e724a6a0b9c3cb888` | ||
| > | ||
| > ### Nested Safe 2 (Security Council): `0xf64bc17485f0B4Ea5F06A96514182FC4cB561977` | ||
| > | ||
| > - Domain Hash: `0xbe081970e9fc104bd1ea27e375cd21ec7bb1eec56bfe43347c3e36c5d27b8533` | ||
| > - Message Hash: `0x7aab487c69b9f7c565a696bec5c74ea6ae486eeb746dabc87e7182d0cc5bf0e7` | ||
|
|
||
| ## Task Calldata | ||
|
|
||
| ``` | ||
| 0x82ad56cb00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000071241bbae674967dd523e621c272ea32cf33119a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000001841a80dc38000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000020000000000000000000000005c1d29c6c9c8b0800692acc95d700bcb4966a1d70000000000000000000000000000000000000000000000001bc16d674ec80000000000000000000000000000ed9b99a703bad32ac96fddc313c0652e379251fd00000000000000000000000000000000000000000000000000000000000c3500000000000000000000000000bea2bc852a160b8547273660e22f4f08c2fa9bbb00000000000000000000000065ea1489741a5d72ffdd8e6485b216bbdcc15af30000000000000000000000000000000000000000000000001bc16d674ec80000000000000000000000000000ed9b99a703bad32ac96fddc313c0652e379251fd00000000000000000000000000000000000000000000000000000000000c3500000000000000000000000000660203dd7e933646905dfdc2c3c0bb156d51000a00000000000000000000000000000000000000000000000000000000 | ||
| ``` |
|
maurelian marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # RevShare Upgrade and Setup Configuration | ||
|
|
||
| templateName = "RevShareUpgradeAndSetup" | ||
|
|
||
| # L2 chains to target | ||
| l2chains = [ | ||
| {name = "Ink Sepolia", chainId = 763373}, | ||
| {name = "Soneium Testnet Minato", chainId = 1946} | ||
| ] | ||
|
|
||
| safeAddress = "ProxyAdminOwner" | ||
|
|
||
| # RevShareContractsUpgrader address | ||
| revShareUpgrader = "0x71241bbae674967dD523e621c272Ea32cf33119A" | ||
|
|
||
| # RevShare configurations (one per chain) - flattened arrays | ||
| portals = [ | ||
| "0x5c1d29C6c9C8b0800692acC95D700bcb4966A1d7", # Ink Sepolia Portal | ||
| "0x65ea1489741A5D72fFdD8e6485B216bBdcC15Af3" # Soneium Testnet Minato Portal | ||
| ] | ||
|
|
||
| chainFeesRecipients = [ | ||
| "0xBeA2Bc852a160B8547273660E22F4F08C2fa9Bbb", | ||
| "0x660203DD7E933646905DfDc2C3c0Bb156d51000A" | ||
| ] | ||
|
|
||
| # 2 ether | ||
| l1WithdrawerMinWithdrawalAmounts = [2000000000000000000, 2000000000000000000] | ||
|
|
||
| # FeesDepositor address in mainnet | ||
| l1WithdrawerRecipients = [ | ||
| "0xed9B99a703BaD32AC96FDdc313c0652e379251Fd", | ||
| "0xed9B99a703BaD32AC96FDdc313c0652e379251Fd" | ||
| ] | ||
| l1WithdrawerGasLimits = [800000, 800000] | ||
|
|
||
| [addresses] | ||
| ProxyAdminOwner = "0x1Eb2fFc903729a0F03966B917003800b145F56E2" | ||
|
|
||
| [stateOverrides] | ||
| # Security Council | ||
| 0xf64bc17485f0B4Ea5F06A96514182FC4cB561977 = [ | ||
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 60} | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.