Skip to content

fix: audit informational findings (#83) #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maurelian merged 2 commits into from
Nov 28, 2025
+14 −11
Merged

fix: audit informational findings (#83) #1308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23a738
fix: audit informational findings (#83)
0xDiscotech Nov 27, 2025
692cab0
Merge branch 'main' into sc-fix/audit-findings
0xDiscotech Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RevShareContractsUpgrader.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ contract RevShareContractsUpgrader {
RevShareCommon.depositCall(
config.portal,
RevShareCommon.FEE_SPLITTER,
FeeVaultUpgrader.SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
abi.encodeCall(IFeeSplitter.setSharesCalculator, (calculator))
);

Expand Down
12 changes: 6 additions & 6 deletions src/libraries/FeeVaultUpgrader.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ library FeeVaultUpgrader {
/// @notice The gas limit for the Fee Vaults deployment.
uint64 internal constant FEE_VAULTS_DEPLOYMENT_GAS_LIMIT = 1_200_000;

/// @notice The gas limit for the Fee Vaults setters.
uint64 internal constant SETTERS_GAS_LIMIT = 50_000;

/// @notice Address of the Operator Fee Vault Predeploy on L2.
address internal constant OPERATOR_FEE_VAULT = 0x420000000000000000000000000000000000001b;

Expand Down Expand Up @@ -103,16 +100,19 @@ library FeeVaultUpgrader {
RevShareCommon.depositCall(
_portal,
vaults[i],
SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
abi.encodeCall(IFeeVault.setRecipient, (RevShareCommon.FEE_SPLITTER))
);
RevShareCommon.depositCall(
_portal, vaults[i], SETTERS_GAS_LIMIT, abi.encodeCall(IFeeVault.setMinWithdrawalAmount, (0))
_portal,
vaults[i],
RevShareCommon.SETTERS_GAS_LIMIT,
abi.encodeCall(IFeeVault.setMinWithdrawalAmount, (0))
);
RevShareCommon.depositCall(
_portal,
vaults[i],
SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
abi.encodeCall(IFeeVault.setWithdrawalNetwork, (IFeeVault.WithdrawalNetwork.L2))
);
}
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/RevShareCommon.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ library RevShareCommon {
/// @notice The gas limit for the upgrade calls on L2.
uint64 internal constant UPGRADE_GAS_LIMIT = 150_000;

/// @notice The gas limit for setter calls on L2.
uint64 internal constant SETTERS_GAS_LIMIT = 75_000;

/// @notice The salt prefix for the RevShare system.
string internal constant SALT_SEED = "RevShare";

Expand Down
8 changes: 4 additions & 4 deletions test/template/revenue-share-upgrade-path/RevShareContractsUpgrader.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ contract RevShareContractsUpgrader_TestInit is Test {
_portal,
abi.encodeCall(
IOptimismPortal2.depositTransaction,
(RevShareCommon.FEE_SPLITTER, 0, FeeVaultUpgrader.SETTERS_GAS_LIMIT, false, setCalculatorCall)
(RevShareCommon.FEE_SPLITTER, 0, RevShareCommon.SETTERS_GAS_LIMIT, false, setCalculatorCall)
),
abi.encode()
);
Expand Down Expand Up @@ -250,7 +250,7 @@ contract RevShareContractsUpgrader_TestInit is Test {
(
_vault,
0,
FeeVaultUpgrader.SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
false,
abi.encodeCall(IFeeVault.setRecipient, (RevShareCommon.FEE_SPLITTER))
)
Expand All @@ -266,7 +266,7 @@ contract RevShareContractsUpgrader_TestInit is Test {
(
_vault,
0,
FeeVaultUpgrader.SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
false,
abi.encodeCall(IFeeVault.setMinWithdrawalAmount, (0))
)
Expand All @@ -282,7 +282,7 @@ contract RevShareContractsUpgrader_TestInit is Test {
(
_vault,
0,
FeeVaultUpgrader.SETTERS_GAS_LIMIT,
RevShareCommon.SETTERS_GAS_LIMIT,
false,
abi.encodeCall(IFeeVault.setWithdrawalNetwork, (IFeeVault.WithdrawalNetwork.L2))
)
Expand Down