Skip to content

U17 OP, Soneium Sepolia#1263

Closed
Wazabie wants to merge 13 commits into
mainfrom
u17-sep-op-sony-ink
Closed

U17 OP, Soneium Sepolia#1263
Wazabie wants to merge 13 commits into
mainfrom
u17-sep-op-sony-ink

Conversation

@Wazabie
Copy link
Copy Markdown
Contributor

@Wazabie Wazabie commented Oct 26, 2025

Jovian U17 upgrade task for OP and Soneium Minato Sepolia

@Wazabie Wazabie requested review from a team as code owners October 26, 2025 11:45
@Wazabie Wazabie requested a review from mds1 October 26, 2025 11:45
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/README.md Outdated
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/VALIDATION.md Outdated
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/config.toml Outdated
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/VALIDATION.md Outdated
@Wazabie Wazabie self-assigned this Oct 27, 2025
Comment thread src/tasks/sep/039-U17-sep-op-sony/VALIDATION.md
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/.env
@@ -0,0 +1,21 @@
# 038-U17-sep-op-sony-ink

Status: [DRAFT, NOT READY TO SIGN]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ready to sign, unless we are unsure about the prestate when we merge this

Comment thread src/tasks/sep/039-U17-sep-op-sony/config.toml Outdated
Comment thread src/tasks/sep/039-U17-sep-op-sony/config.toml Outdated
Comment thread src/tasks/sep/038-U17-sep-op-sony-ink/config.toml Outdated
Comment thread src/tasks/sep/039-U17-sep-op-sony/config.toml Outdated
Comment thread src/tasks/sep/039-U17-sep-op-sony/README.md Outdated
Comment thread src/tasks/sep/039-U17-sep-op-sony/README.md Outdated
@Wazabie Wazabie changed the title U17 OP Soneium Ink Sepolia U17 OP Soneium Sepolia Nov 3, 2025

[addresses]

OPCM = "0xc69e4c24db479191676611a25d977203c3bdca62" # Source: to add reference
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OPCM address comment states 'Source: to add reference' which indicates the address source is not properly documented or verified. For robustness and safety, all critical contract addresses should have verified sources documented to prevent using incorrect addresses that could lead to failed transactions or security issues. The comment should be updated to include the actual source reference where this address was obtained and verified.

Suggested change
OPCM = "0xc69e4c24db479191676611a25d977203c3bdca62" # Source: to add reference
OPCM = "0xc69e4c24db479191676611a25d977203c3bdca62" # Source: https://optimistic.etherscan.io/address/0xc69e4c24db479191676611a25d977203c3bdca62 - Official Sony SEP documentation at https://docs.example.com/sony-sep

Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

# OP Sepolia Testnet (Permissionless)
[[opcmUpgrades]]
chainId = 11155420
absolutePrestate = "0x03caa1871bb9fe7f9b11217c245c16e4ded33367df5b3ccb2c6d0a847a217d1b" # prestates."1.8.0-rc.4" https://www.notion.so/oplabs/U17-2a1f153ee162804f94d0c10d0a1e1258
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The absolutePrestate hash references a Notion document for verification, but there are no instructions in the task documentation for operators to independently verify this critical hash value. For safety and robustness, the task should include steps to verify the prestate hash against official sources or provide checksums, as using an incorrect prestate could lead to upgrade failures or inconsistent chain state.

Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +35 to +42
0x1Eb2fFc903729a0F03966B917003800b145F56E2 = [ # L1PAO
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 38}
]
0xf64bc17485f0B4Ea5F06A96514182FC4cB561977 = [ # SC
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 50}
]
0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B = [ # FUS
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 53}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stateOverrides section modifies critical contract storage slots (nonce values) but lacks documentation explaining what these overrides do and why they are necessary. For robustness and safety, state overrides should be clearly documented with explanations of their purpose, as incorrect state modifications could lead to unexpected behavior or security vulnerabilities. Comments should explain that these appear to be nonce overrides and why specific nonce values are being set.

Suggested change
0x1Eb2fFc903729a0F03966B917003800b145F56E2 = [ # L1PAO
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 38}
]
0xf64bc17485f0B4Ea5F06A96514182FC4cB561977 = [ # SC
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 50}
]
0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B = [ # FUS
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 53}
0x1Eb2fFc903729a0F03966B917003800b145F56E2 = [ # L1PAO
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 38} # Override the nonce value (storage slot 0x5) for the L1PAO contract - Setting nonce to 38 to match the expected state for this test scenario
]
0xf64bc17485f0B4Ea5F06A96514182FC4cB561977 = [ # SC
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 50} # Override the nonce value (storage slot 0x5) for the SC contract - Setting nonce to 50 to match the expected state for this test scenario
]
0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B = [ # FUS
{key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 53} # Override the nonce value (storage slot 0x5) for the FUS contract - Setting nonce to 53 to match the expected state for this test scenario
]

Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@Wazabie Wazabie changed the title U17 OP Soneium Sepolia U17 OP, Soneium Sepolia Nov 5, 2025
@Wazabie Wazabie closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants