Closed
Conversation
* feat: add initial version of predeploys and l2-contracts-manager * chore: moves files to experimental * chore: remove unrelated functions * chore: make clear all network config is gathered * feat: clarify use of gather config * fix: update flow diagram
0xOneTony
reviewed
Nov 14, 2025
|
|
||
| ## Overview | ||
|
|
||
| ## L2ProxyAdmin |
There was a problem hiding this comment.
@maurelian seems like if we want to exclude the different proxy types we would need to create an L2ProxyAdmin from scratch because we cant override the functions if we inherit from ProxyAdmin.
If we dont care about removing the different proxy types then we can inherit from ProxyAdmin and just add the upgradePredeploys spec
0xOneTony
reviewed
Nov 14, 2025
| deploying the `L2ContractsManager` for the target hard fork, and calling `L2ProxyAdmin.upgradePredeploys()`. | ||
| The bundle is client-agnostic and can be consumed by any implementation: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
We will probably need a few more field on the JSON like a commit hash from where this bundle got created, what else?
This was referenced Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specifications for the
L2ContractsManagerproject. These enable deterministic hard fork upgrades of L2 predeploys.ProxyAdminwithupgradePredeploys()and ERC1967-only overridesCreate2Deployerpredeploy, allowing for non-reverting deterministic deployments in case of address collision.Includes invariants, assumptions, function specifications, and security considerations.
Design document