Skip to content

add SupervisorSyncStatus return object to specs#698

Merged
emhane merged 1 commit intomainfrom
nonsense/supervisor_syncstatus
May 9, 2025
Merged

add SupervisorSyncStatus return object to specs#698
emhane merged 1 commit intomainfrom
nonsense/supervisor_syncstatus

Conversation

@nonsense
Copy link
Contributor

@nonsense nonsense commented May 6, 2025

Description

This PR is adding a description of the SupervisorSyncStatus return object, as it is being updated at ethereum-optimism/optimism#15624


The linked PR is adding two new fields to the SupervisorChainSyncStatus struct:

type SupervisorChainSyncStatus struct {
...
	LocalSafe   BlockID  `json:"localSafe"`
	CrossUnsafe BlockID  `json:"crossUnsafe"`
...
}

@nonsense nonsense force-pushed the nonsense/supervisor_syncstatus branch from 668016f to 9a6b53a Compare May 9, 2025 12:50
@nonsense
Copy link
Contributor Author

nonsense commented May 9, 2025

I will mark this as ready for review as soon as the linked PR is merged, as it is changing one of the structs defined here.

@dhyaniarun1993
Copy link
Contributor

I will mark this as ready for review as soon as the linked PR is merged, as it is changing one of the structs defined here.

I believe the spec PR should be merged first since it defines the structure that the implementation PR is based on. The implementation PR is meant to follow the spec, not the other way around.

@nonsense nonsense marked this pull request as ready for review May 9, 2025 14:03
@nonsense nonsense requested review from a team as code owners May 9, 2025 14:03
@clabby
Copy link
Contributor

clabby commented May 9, 2025

I will mark this as ready for review as soon as the linked PR is merged, as it is changing one of the structs defined here.

I believe the spec PR should be merged first since it defines the structure that the implementation PR is based on. The implementation PR is meant to follow the spec, not the other way around.

+1. If you take this out of draft, we can merge it now.

@emhane emhane merged commit 4aedb3f into main May 9, 2025
5 checks passed
@emhane emhane deleted the nonsense/supervisor_syncstatus branch May 9, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants