Add script for generating upgrade tx specs#673
Merged
Conversation
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
2 times, most recently
from
5d4346b to
9b6e587
Compare
teddyknox
changed the title
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
from
9b6e587 to
d0b3baa
Compare
emhane
reviewed
Apr 24, 2025
Contributor
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
can we have a workflow for manually dispatching this script in ci pls?
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
from
d0b3baa to
099875a
Compare
Contributor
Author
|
@emhane as a test? Or what would be the purpose? |
Contributor
for creating new specs when needed and, yes, for not relying on manual test to check its validity |
sebastianst
reviewed
Apr 29, 2025
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
2 times, most recently
from
3706ac1 to
f6ebd7a
Compare
Contributor
|
I would love to merge this but ideally it uses |
geoknee
reviewed
Sep 15, 2025
…2 via uv\npython: update missing dependency hint to use 'uv pip install'
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
from
33fdc79 to
8349d40
Compare
Contributor
Author
|
@geoknee I've updated it to use |
geoknee
reviewed
Sep 18, 2025
geoknee
reviewed
Sep 18, 2025
Merged
Contributor
|
@teddyknox check out #778 for a few more pointers. |
sebastianst
pushed a commit
that referenced
this pull request
Sep 18, 2025
* fix jovian specs We had generated the upgrade transactions with an account which had already been used cast nonce 0x4210000000000000000000000000000000000004 --rpc-url=https://mainnet.optimism.io 1 This means the upgrade transactions would revert. There is already a contract at the address we were trying to deploy to. * commit script to generate specs This anticipates #673 * lint * remove file * whitespace nits
teddyknox
force-pushed
the
upgrade-tx-spec-script
branch
from
b93fca9 to
4eafb0d
Compare
geoknee
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a set of scripts that make it easy to generate specifications for upgrade/proxy update transactions.
Tests
I manually compared the result of this script to previous specifications for upgrade/proxy update transactions, given the same input.
Additional context
Used to generate #672.