isthmus: Clarify SetCode tx type handling in span batches#587
Merged
sebastianst merged 2 commits intomainfrom Feb 10, 2025
Merged
isthmus: Clarify SetCode tx type handling in span batches#587sebastianst merged 2 commits intomainfrom
sebastianst merged 2 commits intomainfrom
Conversation
clabby
approved these changes
Feb 7, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the update.
ajsutton
approved these changes
Feb 9, 2025
refcell
reviewed
Feb 10, 2025
refcell
approved these changes
Feb 10, 2025
clabby
approved these changes
Feb 10, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
Clarification of pre-Holocene behavior looks good. Thanks 
axelKingsley
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also discussion in
ethereum-optimism/optimism#14197