Conversation
tynes
requested review from
ajsutton,
mslipper,
protolambda and
sebastianst
as code owners
Contributor
Author
|
This doesn't include all of the methods, see https://github.com/ethereum-optimism/optimism/blob/develop/op-supervisor/supervisor/frontend/frontend.go#L18-L28 h/t @refcell |
refcell
reviewed
Jan 23, 2025
emhane
reviewed
Jan 24, 2025
This was referenced Feb 7, 2025
Contributor
Author
|
I believe this is now out of date. It would be ideal if we could update this and get it over the line |
API based on op-supervisor March 7 2025
protolambda
force-pushed
the
interop-supervisor-api
branch
from
98776c4 to
b5a031d
Compare
protolambda
approved these changes
Mar 7, 2025
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
I just updated the specs to match the latest actual API. Documentation can still improve, but I strongly think it's better to merge than to keep this PR lingering around. Small PRs can then adjust the wording or add extra bits of information where necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Take a quick pass at the supervisor api. This is useful because there
are many teams integrating into this right now.
op-geth has already integrated, the op-reth integration is ongoing as
well as the rbuilder integration should be happening soon.
This enables us to point to spec as the source of truth in how the API
is meant to work.