This repository was archived by the owner on Aug 20, 2022. It is now read-only.
eth,miner: return STATUS_INVALID when failing to process forced txs#40
Merged
mslipper merged 1 commit intooptimism-historyfrom Aug 5, 2022
Merged
eth,miner: return STATUS_INVALID when failing to process forced txs#40mslipper merged 1 commit intooptimism-historyfrom
mslipper merged 1 commit intooptimism-historyfrom
Conversation
…actions in request
mslipper
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we fail to prepare a block with just the forced transactions from the request then the request must be bad, and we should return
STATUS_INVALID. This way we can handle bad L1 data in the rollup node, and not reattempt to process it.Also update the returned error, so underlying process errors become visible.