This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## sc/base-messenger #429 +/- ##
=====================================================
- Coverage 53.10% 51.54% -1.57%
=====================================================
Files 62 57 -5
Lines 6498 5781 -717
=====================================================
- Hits 3451 2980 -471
+ Misses 2608 2431 -177
+ Partials 439 370 -69
Continue to review full report at Codecov.
|
mslipper
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a fix for the withdrawal window as well as test coverage. We need to do some hardcore testing of the proof validation logic still