Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

fix: withdrawal time#429

Merged
tynes merged 2 commits intosc/base-messengerfrom
fix/withdrawal-time
May 12, 2022
Merged

fix: withdrawal time#429
tynes merged 2 commits intosc/base-messengerfrom
fix/withdrawal-time

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented May 12, 2022

Description
Adds a fix for the withdrawal window as well as test coverage. We need to do some hardcore testing of the proof validation logic still

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #429 (1449e24) into sc/base-messenger (e2da9e2) will decrease coverage by 1.56%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           sc/base-messenger     #429      +/-   ##
=====================================================
- Coverage              53.10%   51.54%   -1.57%     
=====================================================
  Files                     62       57       -5     
  Lines                   6498     5781     -717     
=====================================================
- Hits                    3451     2980     -471     
+ Misses                  2608     2431     -177     
+ Partials                 439      370      -69     
Impacted Files Coverage Δ
opnode/contracts/deposit/deposit_feed_raw.go 5.21% <ø> (ø)
opnode/l2/api.go 60.00% <0.00%> (-14.20%) ⬇️
opnode/test/geth.go 63.93% <0.00%> (-0.87%) ⬇️
bss/sequencer/driver.go 74.26% <0.00%> (-0.74%) ⬇️
opnode/test/setup.go 72.12% <0.00%> (-0.70%) ⬇️
opnode/service.go 0.00% <0.00%> (ø)
opnode/eth/heads.go 69.56% <0.00%> (ø)
opnode/node/config.go 33.33% <0.00%> (ø)
opnode/rollup/types.go 18.18% <0.00%> (ø)
opnode/rollup/driver/driver.go 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2da9e2...1449e24. Read the comment docs.

@tynes tynes mentioned this pull request May 12, 2022
@tynes tynes merged commit 756e2a5 into sc/base-messenger May 12, 2022
@tynes tynes deleted the fix/withdrawal-time branch May 12, 2022 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants