This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 39.70% 39.69% -0.02%
==========================================
Files 50 50
Lines 6301 6301
==========================================
- Hits 2502 2501 -1
- Misses 3491 3492 +1
Partials 308 308
Continue to review full report at Codecov.
|
The `L1StandardBridge` does not hold on to ETH balances, the `OptimismPortal` does so. When depositing/withdrawing ETH through the standard bridge, the `OptimismPortal` must forward ETH to the `L1StandardBridge` for it to be forwarded to the user. This means that the `finalizeETHWithdrawal` function needs to be `payable`. This commit pulls in the interfaces for the `IL1ERC20Bridge` and the `IL1StandardBridge` contracts and adds a `payable` modifier to `finalizeETHWithdrawal`. This is a diff from the previous deployment of the contracts, but it does not impact the ABI so there is no diff for the end user because this function is only callable by a smart contract.
When using the L1 bridge, the ETH deposit should go through the L2 bridge.
tynes
force-pushed
the
test/l1standardbridge
branch
from
804b866 to
067c60b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for the
L1StandardBridgecontract. Adding these tests found a bug wherefinalizeETHWithdrawalshould bepayablebecause theOptimismPortalneeds to sendETH to it to be forwarded to the end user.