Skip to content

fix(proxyd): log initialization#9785

Merged
felipe-op merged 2 commits into
developfrom
felipe/proxyd-fix-log
Mar 8, 2024
Merged

fix(proxyd): log initialization#9785
felipe-op merged 2 commits into
developfrom
felipe/proxyd-fix-log

Conversation

@felipe-op
Copy link
Copy Markdown
Contributor

@felipe-op felipe-op commented Mar 7, 2024

Description

This change fixes log initialization.

Tests

Tested manually.

@felipe-op felipe-op requested a review from a team as a code owner March 7, 2024 23:47
@felipe-op felipe-op requested a review from zhwrd March 7, 2024 23:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 7, 2024

Walkthrough

Walkthrough

The primary change involves transitioning the logging framework in the proxyd application from slog to log, enhancing the default logger setup. This shift simplifies how logging is managed and configured, impacting both the main application logic and integration testing utilities.

Changes

File Path Change Summary
.../proxyd/main.go Updated default logger setup from slog to log in main() function.
.../proxyd/integration_tests/util_test.go Utilized log package for default logger with JSON handler in InitLogger.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Comment thread proxyd/cmd/proxyd/main.go
Comment thread proxyd/cmd/proxyd/main.go
@felipe-op
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app Bot commented Mar 7, 2024

Semgrep found 10 sol-style-return-arg-fmt findings:

  • packages/contracts-bedrock/scripts/Deployer.sol: L148, L126, L79, L66
  • packages/contracts-bedrock/scripts/DeployPeriphery.s.sol: L28
  • packages/contracts-bedrock/scripts/Artifacts.s.sol: L272, L249, L247, L240, L54

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

  • packages/contracts-bedrock/scripts/Deployer.sol: L173, L153

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Comment thread proxyd/integration_tests/util_test.go
@felipe-op felipe-op enabled auto-merge March 8, 2024 00:10
@felipe-op felipe-op added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit 713f288 Mar 8, 2024
@felipe-op felipe-op deleted the felipe/proxyd-fix-log branch March 8, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants