Skip to content

Comments

Init new bindings#8284

Merged
Spacesai1or merged 1 commit intodevelopfrom
wyatt/bindgen/init-new-bindings
Dec 19, 2023
Merged

Init new bindings#8284
Spacesai1or merged 1 commit intodevelopfrom
wyatt/bindgen/init-new-bindings

Conversation

@Spacesai1or
Copy link
Contributor

@Spacesai1or Spacesai1or commented Nov 27, 2023

This PR commits the new bindings and metadata files for the contracts listed in #8281

@Spacesai1or
Copy link
Contributor Author

Spacesai1or commented Nov 27, 2023

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Nov 27, 2023

Semgrep found 2 import-text-template findings:

  • op-bindings/bindgen/remote_handlers.go: L11
  • op-bindings/bindgen/generator_local.go: L12

When working with web applications that involve rendering user-generated content, it's important to properly escape any HTML content to prevent Cross-Site Scripting (XSS) attacks. In Go, the text/template package does not automatically escape HTML content, which can leave your application vulnerable to these types of attacks. To mitigate this risk, it's recommended to use the html/template package instead, which provides built-in functionality for HTML escaping. By using html/template to render your HTML content, you can help to ensure that your web application is more secure and less susceptible to XSS vulnerabilities.

Ignore this finding from import-text-template.

@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 70b096a to 480415f Compare November 27, 2023 06:16
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch 2 times, most recently from 6758a75 to b8385d6 Compare November 27, 2023 20:28
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from b10601a to 7b75e77 Compare November 27, 2023 20:29
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from b8385d6 to 625da98 Compare November 27, 2023 20:31
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from 7cfdb2b to c741a7b Compare November 27, 2023 21:02
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 625da98 to bfbf4a4 Compare November 27, 2023 21:02
@Spacesai1or Spacesai1or marked this pull request as draft November 27, 2023 21:32
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from c741a7b to 44c1bf2 Compare November 27, 2023 22:29
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from bfbf4a4 to d1fdd2b Compare November 27, 2023 22:29
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from 44c1bf2 to a86bc09 Compare November 27, 2023 22:40
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from d1fdd2b to 4c7f238 Compare November 27, 2023 22:40
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from a86bc09 to aa63240 Compare November 27, 2023 22:44
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 4c7f238 to 7699722 Compare November 27, 2023 22:44
@Spacesai1or Spacesai1or marked this pull request as ready for review November 28, 2023 21:10
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from aa63240 to 7ba3ace Compare December 1, 2023 04:15
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 7699722 to e225b0d Compare December 1, 2023 04:15
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Dec 1, 2023

Semgrep found 6 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 1 sol-style-input-arg-fmt finding:

  • packages/contracts-bedrock/scripts/Deployer.sol: L373

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

@Spacesai1or Spacesai1or marked this pull request as draft December 1, 2023 19:29
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from cb17fd9 to 7ce2bbb Compare December 14, 2023 21:16
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 387bd69 to 6b7a25e Compare December 14, 2023 21:16
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from 7ce2bbb to f49bc2a Compare December 14, 2023 21:55
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 6b7a25e to 4113c21 Compare December 14, 2023 21:55
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from f49bc2a to dd5b1c6 Compare December 14, 2023 22:20
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 4113c21 to 263751e Compare December 14, 2023 22:20
@Spacesai1or
Copy link
Contributor Author

Running make bindgen-local on develop is yielding changes to all the previously unchanged binding outputs. The diffs appears to only be the ABI output with just reordering of the properties. This hasn't happened before and I'm not sure what's causing it. This PR will need to be updated with the new binding outputs though

@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from dd5b1c6 to afc6fc6 Compare December 14, 2023 23:38
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 263751e to bd2c068 Compare December 14, 2023 23:38
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bindings will likely need to be regenerated again prior to merge, but otherwise this looks good.

@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/output-overwrite-warning branch from afc6fc6 to 48d47f6 Compare December 15, 2023 19:46
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from bd2c068 to 52bc6f2 Compare December 15, 2023 19:46
@Spacesai1or
Copy link
Contributor Author

Latest push updates bindings

@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 52bc6f2 to 000e1de Compare December 15, 2023 20:04
@Spacesai1or
Copy link
Contributor Author

op-bindings-build test is failing because it's git diffing the bindings output against previous, but because the existing bindings were updated the test fails - not sure how to update

Base automatically changed from wyatt/bindgen/output-overwrite-warning to develop December 16, 2023 06:29
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 000e1de to 3276fa8 Compare December 16, 2023 07:25
@codecov
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #8284 (7cfdb2b) into develop (da2e8c5) will increase coverage by 4.73%.
The diff coverage is n/a.

❗ Current head 7cfdb2b differs from pull request most recent head d7f7658. Consider uploading reports for the commit d7f7658 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8284      +/-   ##
===========================================
+ Coverage    34.57%   39.30%   +4.73%     
===========================================
  Files          167      102      -65     
  Lines         7170     3358    -3812     
  Branches      1213      438     -775     
===========================================
- Hits          2479     1320    -1159     
+ Misses        4539     1964    -2575     
+ Partials       152       74      -78     
Flag Coverage Δ
cannon-go-tests 63.48% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 21.43% <ø> (+1.19%) ⬆️
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 82 files with indirect coverage changes

This was referenced Dec 17, 2023
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from 3276fa8 to b6428aa Compare December 18, 2023 23:17
@Spacesai1or Spacesai1or force-pushed the wyatt/bindgen/init-new-bindings branch from b6428aa to d7f7658 Compare December 19, 2023 00:10
@Spacesai1or Spacesai1or added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit ddeab49 Dec 19, 2023
@Spacesai1or Spacesai1or deleted the wyatt/bindgen/init-new-bindings branch December 19, 2023 00:58
ArtyomArtamonov pushed a commit to ArtyomArtamonov/optimism that referenced this pull request Dec 19, 2023
roberto-bayardo pushed a commit to roberto-bayardo/optimism that referenced this pull request Dec 19, 2023
roberto-bayardo pushed a commit to roberto-bayardo/optimism that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants