op-service: Ensure block body validation tests fail for the expected reason#8064
Merged
op-service: Ensure block body validation tests fail for the expected reason#8064
Conversation
…reason. Adds coverage for nil transactions and withdrawals and blocks with correct block hash but a transaction or withdrawal root that doesn't match the body. Removes the generation of body tests from the script as the generated scripts were a useful start, but ultimately ineffective at testing the code.
Inphi
reviewed
Nov 7, 2023
op-service/sources/testdata/data/blocks/post-shanghai-bad-transactions-hash_metadata.json
Show resolved
Hide resolved
Inphi
reviewed
Nov 7, 2023
Contributor
Author
|
ugh, sorry for the noise - GitHub wasn't showing my comments as posted, hence the repeated attempts. Now it's showing up... |
Inphi
approved these changes
Nov 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a reason to the rpc block validation tests to ensure that the block is rejected for the intended reason and not for an unintended error in the test data (typically the block hash not matching).
Adds coverage for:
Previously all tests would pass even if the validation of the actual transactions and withdrawals was completely removed.
The block body tests are no longer generated by the
gen.shscript because while these were a useful starting point, they were quite limited in what they actually tested. Manually modifying the content was a lot easier than having the generation script compute correct block hashes etc.Noticed the lack of test coverage in #7993.