Skip to content

dtl: fix syncing off by one #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tynes merged 2 commits into from
Apr 29, 2021
Merged

dtl: fix syncing off by one #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b32ddd
dtl: syncing off by one error
tynes Apr 29, 2021
a92c295
chore: add changeset
tynes Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blue-needles-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eth-optimism/data-transport-layer": patch
---

Account for the off by one with regards to the l2geth block number and the CTC index
2 changes: 1 addition & 1 deletion packages/data-transport-layer/src/services/server/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class L1TransportServer extends BaseService<L1TransportServerOptions> {
break
case 'l2':
currentL2Block = await this.state.db.getLatestUnconfirmedTransaction()
highestL2BlockNumber = await this.state.db.getHighestSyncedUnconfirmedBlock()
highestL2BlockNumber = (await this.state.db.getHighestSyncedUnconfirmedBlock()) - 1
break
default:
throw new Error(`Unknown transaction backend ${backend}`)
Expand Down