Skip to content

feat: RLP transactions #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlfloersch wants to merge 2 commits into from
Closed

feat: RLP transactions #567

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a620463
feat: Attempt to decode txs as RLP first (#563)
karlfloersch Apr 22, 2021
9318ad3
l2geth: remove eth_sendRawEthSignTransaction endpoint (#589)
tynes Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,31 @@ const maybeDecodeSequencerBatchTransaction = (
let decoded = null
let type = null

try {
// Try to decode as RLP first. This function will throw if the transaction can't be properly
// decoded as RLP and we'll get bumped down to the next set of possible decodings.
const decodedTx = ethers.utils.parseTransaction(transaction)

return {
type: 'EIP155',
decoded: {
nonce: BigNumber.from(decodedTx.nonce).toNumber(),
gasPrice: BigNumber.from(decodedTx.gasPrice).toNumber(),
gasLimit: BigNumber.from(decodedTx.gasLimit).toNumber(),
target: toHexString(decodedTx.to), // Maybe null this out for creations?
data: toHexString(decodedTx.data),
sig: {
v: BigNumber.from(decodedTx.v).toNumber(),
r: toHexString(decodedTx.r),
s: toHexString(decodedTx.s),
},
type: 0, // EIP155 legacy holdover.
},
}
} catch (err) {
// Do nothing, fall back to legacy decode.

@snario snario Apr 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment a Counter here; cc @annieke

}

try {

@tynes tynes Apr 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this decoding anymore because we don't have to be backwards compatible

@tynes tynes Apr 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is added to semver version 0.3.x

const txType = transaction.slice(0, 1).readUInt8()
if (txType === TxType.EIP155) {
Expand Down