Skip to content

fix: fix incorrectly provided error object to pino #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snario merged 2 commits into from
Apr 21, 2021
Merged

fix: fix incorrectly provided error object to pino #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
803a30a
fix: fix incorrectly provided error object to pino
snario Apr 21, 2021
5563bcd
build: add changeset
snario Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-onions-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eth-optimism/batch-submitter": patch
---

Correctly formatted error object to log exceptions
4 changes: 2 additions & 2 deletions packages/batch-submitter/src/exec/run-batch-submitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export const run = async () => {
}
}
} catch (err) {
log.error('Cannot clear transactions', err)
log.error('Cannot clear transactions', { err })
process.exit(1)
}
}
Expand All @@ -222,7 +222,7 @@ export const run = async () => {
try {
await func()
} catch (err) {
log.error('Error submitting batch', err)
log.error('Error submitting batch', { err })
log.info('Retrying...')
}
// Sleep
Expand Down