Skip to content

feat: add Sentry release automation #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snario merged 2 commits into from
Apr 22, 2021
Merged

feat: add Sentry release automation #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be3cc60
feat: add Sentry release automation
snario Apr 21, 2021
933880d
build: add changeset
snario Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/big-parents-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@eth-optimism/batch-submitter": patch
"@eth-optimism/data-transport-layer": patch
---

Adds a release version to batch-submitter and data-transport-layer usage of Sentry
3 changes: 3 additions & 0 deletions packages/batch-submitter/exec/run-batch-submitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/env node

console.log(process.env.npm_package_version);
process.exit(1)

const batchSubmitter = require("../dist/src/exec/run-batch-submitter")

batchSubmitter.run()
1 change: 1 addition & 0 deletions packages/batch-submitter/src/exec/run-batch-submitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
const log = new Logger({
name: 'oe:batch-submitter:init',
sentryOptions: {
release: `@eth-optimism/batch-submitter@${process.env.npm_package_version}`,
Copy link
Contributor

@tynes tynes Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this injected in at runtime by yarn?

Copy link
Contributor Author

@snario snario Apr 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally like this:

❯ cat exec/run-batch-submitter.js
console.log(process.env.npm_package_version);

❯ yarn start
$ node ./exec/run-batch-submitter.js
0.1.12

Copy link
Contributor

@tynes tynes Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that yarn or npm MUST be the entrypoint or it will be undefined

dsn: process.env.SENTRY_DSN,
tracesSampleRate: 0.05,
},
Expand Down
1 change: 1 addition & 0 deletions packages/data-transport-layer/src/services/server/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export class L1TransportServer extends BaseService<L1TransportServerOptions> {
this.state.app = express()
Sentry.init({
dsn: this.options.sentryDsn,
release: `@eth-optimism/data-transport-layer@${process.env.npm_package_version}`,
integrations: [
new Sentry.Integrations.Http({ tracing: true }),
new Tracing.Integrations.Express({
Expand Down