Skip to content

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Feb 2, 2021

Description

Adds 0x prefixes where they are missing as well as decodes the v value in the signature as an integer to follow how ethers does it.

Contributing Agreement

@tynes tynes requested review from karlfloersch and smartcontracts and removed request for smartcontracts February 2, 2021 21:20
Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tynes tynes merged commit c916a7f into master Feb 2, 2021
@tynes tynes deleted the fix/signature branch February 2, 2021 21:41
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
theochap pushed a commit that referenced this pull request Jan 15, 2026
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Closes #332.

## Solution

Add feature propagation checks to CI.


## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
emhane pushed a commit that referenced this pull request Feb 3, 2026
Fixes a potential DoS vector of overflowing the stack by writing
zero values to storage. Resolves #401, #394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants