Skip to content

feat(ctb): MerkleTrie fuzzing #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clabby wants to merge 15 commits into from
Closed

feat(ctb): MerkleTrie fuzzing #4008

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b6058a3
feat(ctb): explicit throw in trie get
smartcontracts Oct 25, 2022
d73ee8e
Start go version of merkle trie input fuzzer
clabby Nov 15, 2022
f6d0738
Add changeset
clabby Nov 15, 2022
7119e4a
Working version w/ valid trie / proof
clabby Nov 15, 2022
83c4550
Update bindings
clabby Nov 16, 2022
7ef6cb3
Use regular fuzz test; Gas snapshot upset w/ gas variance in loop ver…
clabby Nov 16, 2022
c83a0ec
Start addressing feedback; transfer to desktop
clabby Nov 17, 2022
9f8a8f9
:broom:; start to modularize `go-fuzz`
clabby Nov 17, 2022
d033241
Start adding some negative fuzz cases
clabby Nov 17, 2022
eb29cf9
Bindings, snapshot, etc
clabby Nov 18, 2022
d6616f4
Apply some of Joshua's feedback / update `go-fuzz` README
clabby Nov 28, 2022
aba1658
Clean up `trieTestCase` struct
clabby Nov 28, 2022
2a0ee35
Merge branch 'sc/ctb-mini-trie-refactor' into @clabby/ctb/merkle-trie…
clabby Nov 29, 2022
a3aec4b
Add more negative test cases
clabby Dec 1, 2022
c84e567
Update gas snapshot / lint
clabby Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-phones-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/contracts-bedrock': patch
---

Adds a fuzz input generator for testing Bedrock's `MerkleTrie.sol`
5 changes: 5 additions & 0 deletions .changeset/spicy-buckets-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/contracts-bedrock': minor
---

Refactors the MerkleTrie get function to throw explicitly instead of returning an existence boolean
1 change: 1 addition & 0 deletions go.work
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use (
./op-node
./op-proposer
./op-service
./packages/contracts-bedrock/go-fuzz
./proxyd
./teleportr
)
Expand Down
3 changes: 3 additions & 0 deletions go.work.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ cloud.google.com/go/compute v1.6.1/go.mod h1:g85FgpzFvNULZ+S8AYq87axRKuf2Kh7deLq
github.com/BurntSushi/toml v1.1.0 h1:ksErzDEI1khOiGPgpwuI7x2ebx/uXQNw7xJpn9Eq1+I=
github.com/BurntSushi/toml v1.1.0/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
github.com/btcsuite/btcd/btcec/v2 v2.1.3/go.mod h1:ctjw4H1kknNJmRN4iP1R7bTQ+v3GJkZBd6mui8ZsAZE=
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f h1:bAs4lUbRJpnnkd9VhRV3jjAVU7DJVjMaK+IsvSeZvFo=
github.com/btcsuite/goleveldb v1.0.0 h1:Tvd0BfvqX9o823q1j2UZ/epQo09eJh6dTcRp79ilIN4=
github.com/btcsuite/snappy-go v1.0.0 h1:ZxaA6lo2EpxGddsA8JwWOcxlzRybb444sgmeJQMJGQE=
github.com/cilium/ebpf v0.4.0/go.mod h1:4tRaxcgiL706VnOzHOdBlY8IEAIdxINsQBcU4xJJXRs=
github.com/cncf/xds/go v0.0.0-20210805033703-aa0b78936158/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/coreos/go-systemd v0.0.0-20181012123002-c6f51f82210d h1:t5Wuyh53qYyg9eqn4BbnlIT+vmhyww0TatL+zT3uWgI=
Expand Down
2 changes: 1 addition & 1 deletion op-bindings/bindings/erc20.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion op-bindings/bindings/gaspriceoracle_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion op-bindings/bindings/governancetoken_more.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading