Skip to content

feat(cmn): keep raw body in requests #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Sep 26, 2022
Merged

feat(cmn): keep raw body in requests #3550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b52e24
feat(cmn): keep raw body in requests
smartcontracts Sep 24, 2022
29635de
Merge branch 'develop' into sc/cmn-raw-body
mergify[bot] Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-trees-kneel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/common-ts': patch
---

Minor update to BaseServiceV2 to keep the raw body around when requests are made.
10 changes: 9 additions & 1 deletion packages/common-ts/src/base-service/base-service-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,17 @@ export abstract class BaseServiceV2<
const app = express()

// Body parsing.
app.use(bodyParser.json())
app.use(bodyParser.urlencoded({ extended: true }))

// Keep the raw body around in case the application needs it.
app.use(
bodyParser.json({
verify: (req, res, buf, encoding) => {
;(req as any).rawBody = buf?.toString(encoding || 'utf8') || ''
},
})
)

// Logging.
app.use(
morgan('short', {
Expand Down