Skip to content

op-proposer,op-service: fix txmgr lint + deprecated func lint #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mslipper merged 1 commit into from
Aug 26, 2022
Merged

op-proposer,op-service: fix txmgr lint + deprecated func lint #3318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion op-proposer/txmgr/txmgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ func waitMined(

// CalcGasFeeCap deterministically computes the recommended gas fee cap given
// the base fee and gasTipCap. The resulting gasFeeCap is equal to:
// gasTipCap + 2*baseFee.
//
// gasTipCap + 2*baseFee.
func CalcGasFeeCap(baseFee, gasTipCap *big.Int) *big.Int {
return new(big.Int).Add(
gasTipCap,
Expand Down
5 changes: 3 additions & 2 deletions op-service/rpc/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package rpc

import (
"fmt"
"io/ioutil"
"io"
"math/rand"
"net/http"
"testing"
Expand Down Expand Up @@ -41,7 +41,8 @@ func TestBaseServer(t *testing.T) {
t.Run("supports GET /healthz", func(t *testing.T) {
res, err := http.Get(fmt.Sprintf("http://%s/healthz", server.endpoint))
require.NoError(t, err)
body, err := ioutil.ReadAll(res.Body)
defer res.Body.Close()
body, err := io.ReadAll(res.Body)
require.NoError(t, err)
require.EqualValues(t, fmt.Sprintf("{\"version\":\"%s\"}\n", appVersion), string(body))
})
Expand Down
2 changes: 1 addition & 1 deletion specs/meta/linting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ Justification for linting rules:
# Install linter globally (should not affect go.mod)
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.48.0
# run linter, add --fix option to fix problems (where supported)
golangci-lint run -E asciicheck,goimports,misspell
golangci-lint run -E goimports,sqlclosecheck,bodyclose,asciicheck,misspell
```